Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "[sheet" to the texture special commands. #4861

Closed
wants to merge 1 commit into from
Closed

Added "[sheet" to the texture special commands. #4861

wants to merge 1 commit into from

Conversation

sofar
Copy link
Contributor

@sofar sofar commented Dec 8, 2016

"[sheet:W:H:X:Y" assumes the base image is a tilesheet with W*H tiles
on it and crops to the tile at position X,Y. Basically it works
like "[verticalframe" but in 2d.

For testing, I combined the four default_chest images into one.

"[sheet:W:H:X:Y" assumes the base image is a tilesheet with W*H tiles
on it and crops to the tile at position X,Y.  Basically it works
like "[verticalframe" but in 2d.

For testing, I combined the four default_chest images into one.
@sofar
Copy link
Contributor Author

sofar commented Dec 8, 2016

This is a rebased, and tested #1686.

@sofar
Copy link
Contributor Author

sofar commented Dec 8, 2016

This had one 👍 from @sfan5? @nerzhul ok with this rebase?

@est31 est31 added the Feature ✨ PRs that add or enhance a feature label Dec 8, 2016
@est31
Copy link
Contributor

est31 commented Dec 8, 2016

Blocked by feature freeze.

@nerzhul nerzhul added this to the 0.4.16 milestone Dec 8, 2016
@maikerumine
Copy link

Dang. I really like this feature, use one image for many nodes. Or locate a mob face in a texture to make a head. This would be a great resource saver.

@HybridDog
Copy link
Contributor

HybridDog commented Dec 9, 2016

Does sheet work faster than verticalframe?
And is it possible to improve performance by applying multiple modifiers at once instead of one after another?

@sfan5
Copy link
Member

sfan5 commented Dec 9, 2016

And is it possible to improve performance by applying multiple modifiers at once instead of one after another?

I'm assuming you mean the code, it makes absolutely zero difference. Additionally this would cause inefficiencies with textures already partially generated in the past.

@pithydon
Copy link

Cool, I could use this for my rdis mod.

@paramat
Copy link
Contributor

paramat commented Dec 23, 2016

This PR now included in #4952

@sofar sofar closed this Dec 24, 2016
@sofar sofar deleted the 1686 branch December 24, 2016 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature ✨ PRs that add or enhance a feature One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants