Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EmergeManager::getBlockSeed() #488

Closed
wants to merge 1 commit into from

Conversation

ShadowNinja
Copy link
Member

No description provided.

@doserj
Copy link
Contributor

doserj commented Feb 13, 2013

What's the difference to get_blockseed() in mapgen_v6.cpp? should they do the same thing? should only one of them be defined?

I agree that currently the function is broken. But your fix still makes it behave differently to get_blockseed() in mapgen_v6.cpp

@ShadowNinja
Copy link
Member Author

I made the functions similar and I am not sure what the difference is, you should ask @kwolekr.

@kwolekr
Copy link
Contributor

kwolekr commented Feb 17, 2013

Thanks for pointing this out, but I have it fixed in my new_emerge branch along with a bunch of other miscellaneous fixes.
With this changed, papyrus and ore will be back in their exact positions as they were in 0.4.3.. it shouldn't cause a worrying amount of inconsistency in maps.

@kwolekr kwolekr closed this Feb 17, 2013
@ShadowNinja ShadowNinja deleted the mapgen_seed_fix branch February 18, 2013 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants