Various anticheat improvements

[sfan5]

No description provided.

[est31]

It looks good, but what is the "Do 'interact' privilege check first" commit needed for?

[sfan5]

@est31
It makes no sense to do the range check and report a cheat violation to Lua when the player can't interact generally anyway.

[est31]

Well, I guess a better error message means improvement

👍

[lhofhansl]

FWIW: 👍

[Fixer-007]

There is another commit added here that prevents taking your bones after death by clicking Respawn and then bones. 👍

[sfan5]

b16252d

[lhofhansl]

@sfan5 Seems that I am getting this in legitimate cases as well:
2016-12-29 09:35:47: ACTION[Server]: Player Lars tried to access [node under=-179,23,193 above=-179,23,192] from too far: d=62.5343, max_d=40. ignoring.

This is hitting some leaves with a diamond sword. Seems that it's picking up the BS * 4.0 case.

[lhofhansl]

It seems itemDef range and hand range are always -1.

[lhofhansl]

Perhaps a guess, but perhaps the factor should be sqrt(3) ~= 1.73 instead of 1.5, if one reaches out diagonally. In fact the largest distance that was rejected I could manage was 67.53. 67.53/40 ~= 1.688.