Fixed key names so the key set menu now works. #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TMinusPaperclip Thanks for that - I replaced some other oversights as well. |
|
Hi Adam, Thanks for this commit fixed a few issues I was having on my windows system when changing controls. Also I think you missed KEY_RETURN ;) |
|
@dannydark Thanks for the notice - that appears to be all of them. |
|
Is this patch still valid and useful? |
|
Is for my windows system (not had the same problems with key binding on linux) I merged this with the latest dev build a few days ago and seems to fix some key binding issues for me. |
|
Yes, it's still useful. |
|
Should be - it'll probably be better to copy https://github.com/adamnew123456/minetest/blob/master/src/keycode.cpp over the head and commit that than to try to merge the whole thing. |
This was referenced Feb 27, 2013
This was referenced Feb 11, 2015
This was referenced Feb 17, 2016
Closed
Closed
Closed
ghost
mentioned this pull request
leonardoguidoni
pushed a commit
to leonardoguidoni/minetest
that referenced
this pull request
Nov 13, 2019
evanslify
pushed a commit
to uccuhacker/minetest
that referenced
this pull request
Sep 5, 2020
Fix loaded texture log spam
JosiahWI
pushed a commit
to JosiahWI/minetest
that referenced
this pull request
Jan 12, 2023
Keyboard input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somebody forgot to update the other half of the names in
keycode.cpp. I corrected to their proper Irrlicht names.