Remove guest nicknames

[red-001]

See #1059. This PR removes the code that used to generate guest names (it's currently broken) and adds a new error message which tells the player to choose a username.

[nerzhul]

It's a controversial issue, @est31 and @SmallJoker explain us why you are against ?
guest are indesirable and forbidden on many public servers, and don't use private servers (they are not real guest in that case).

[ghost]

Instead "guest" should be "IamtoolazychangeNickname" ...

[est31]

I like that you can simply join a server and play on it. E.g. when I first tried minetest, I wasn't even sure how joining servers worked, whether I had to register first somewhere or not. With a guest account you can ask these questions in ingame chat.

[Desour]

Instead of disabling this feature to be a "Guest####" it would be nice if when they leave the server the guests would be killed (with old? bones) and their player files deleted.
It's annoying having players on server which join, grab some stuff from "Free Items" chests & co. and leave again. Also there's no admin which would grant guests special privs (or even basic ones).

[est31]

@DS-Minetest things like these are up to the server admin, and should be.

[red-001]

This adds a error message that should make it clear that you can just choose any name. I think the correct way to solve new players being clueless would be to include a tutorial.

[paramat]

There seems to be some confusion over what this does, can you improve the description?
This now sends a message to choose a name if it has been left blank, but does the message appear in the menu? I suspect there's a better way.
I support removing the automatic creation of guest names, they annoy all who see them, but the menu should somehow encourage a name to be entered.

[red-001]

@paramat Yes it shows a message in the menu.

[paramat]

👍

[twoelk]

"IamtoolazychangeNickname" may not be always true. Sometimes it's also "cannotchangenickname" or rather simply not being able to type on the client. The reasons could be pure laziness but also being unfamiliar with the letters or text as such due to young age, other script cultur or just being a bot.
Also thick fingers on tiny screens might also motivate to just click enough "ok" buttons until one can finally join.
So what is minetest supposed to do if the joining client fails to provide a nickname?
Is this along the lines of "if your telephone does not work, give us a call on the phone" ?

[paramat]

If a player can't type on an on-screen keyboard (highly unlikely) they will have problems using a smartphone or playing anyway. A few mistyped letters in a name will not matter. If they're very young or disabled they will already need someone helping them to use a smartphone.

[ghost]

Creating a user name (and password btw) at first connecting to a online game server is a reasonable prerequisite. +1

[ShadowNinja]

👍 I've been wanting this for a long time. Many servers already disallow these players anyways.

[nerzhul]

community should find a concensus but @ShadowNinja is right

[red-001]

I think the fact that the code was broken for quite sometime without anyone even making a bug request should show that people don't seem to care too much about guest nicknames.

[paramat]

@nerzhul perhaps you can add your +1 too?

[nerzhul]

I'm for this too

[paramat]

e2ad76f