[CSM] Improve security #5100

red-001 · 2017-01-22T23:15:31Z

No description provided.

nerzhul · 2017-01-23T07:00:37Z

@sapier is this correct for you ?

sfan5 · 2017-01-23T12:59:40Z

src/script/cpp_api/s_security.cpp

+		"date",
+		"difftime",	
+		"time",
+		"setlocale",


just remove it here instead of setting it to nil in init.lua

it's used by bultin.

sfan5 · 2017-01-23T13:00:47Z

src/script/cpp_api/s_security.cpp

+		"setlocale",
+	};
+	static const char *debug_whitelist[] = {
+		"getinfo",


combined with the other changed this effectively disables the debug library, why?

ask @sapier

usually debug code provides a lot of information about internal things.
e.g. some of the debug functions provide access to local variables of other functions.
As debug usually ain't used by anything productive disabling it completely is the savest way to get rid of those issues. Of course you could check each debug fct on it's own but I assume if you remove all potentially unsave ones debug wouldn't be usefull anyway ;-)

rubenwardy · 2017-01-23T00:16:25Z

src/script/cpp_api/s_security.cpp

+		"math",
+	};
+	static const char *io_whitelist[] = {
+		"close",


client side lua should not be able to read the filesystem at all, apart dofile

in fact, reading FS okay, but only in selected places. Client side mode can have logs, or local data (for example imagine pure client side notes, like a journal)

logs

Should use an api feature for this

local data

Should use a virtual filesystem similar to HTML5's webstorage/localstorage

I agree to rubenwardy. Deciding which path to access is quite hard if you consider the corner cases. If you limit to a single mod specific folder you're basically imitating a virtual filesystem. If not you risk missing some critical parts. e.g. /tmp usually is fine for local applications but there's a lot of data stored in /tmp you don't want someone from outside your machine to access.

sapier · 2017-01-23T18:08:12Z

src/script/cpp_api/s_security.cpp

+	SECURE_API(g, dofile);
+	SECURE_API(g, loadstring);
+	SECURE_API(g, require);
+	lua_pop(L, 1);


check if these save functions are save enough for clientside

sapier · 2017-01-23T18:08:29Z

src/script/cpp_api/s_security.cpp

+	SECURE_API(io, input);
+	SECURE_API(io, output);
+	SECURE_API(io, lines);
+


check if these save functions are save enough for clientside same her especially for open

ShadowNinja · 2017-01-24T05:51:51Z

The jit part should check USE_LUAJIT, but more importantly I think the duplication between the security initialization functions should be substantially reduced.

nerzhul · 2017-01-27T07:03:51Z

can you rebase @red-001 ?

paramat · 2018-01-17T03:01:26Z

Lacking description.

nerzhul added the @ Client Script API label Jan 23, 2017

red-001 mentioned this pull request Jan 23, 2017

Client side scripting/modding #5088

Merged

13 tasks

sfan5 reviewed Jan 23, 2017

View reviewed changes

rubenwardy reviewed Jan 23, 2017

View reviewed changes

sapier reviewed Jan 23, 2017

View reviewed changes

red-001 force-pushed the improve_security branch from 1bea2cd to fad8ff5 Compare January 24, 2017 21:47

nerzhul force-pushed the client_side_modding branch 2 times, most recently from b4aaca4 to 635507c Compare January 26, 2017 21:47

nerzhul added the Rebase needed The PR needs to be rebased by its author. label Jan 27, 2017

Improve security for client-sided mods

1c2bce5

red-001 force-pushed the improve_security branch from fad8ff5 to 1c2bce5 Compare January 27, 2017 18:50

Zeno- removed the Rebase needed The PR needs to be rebased by its author. label Jan 28, 2017

nerzhul merged commit d696b0d into minetest:client_side_modding Jan 28, 2017

nerzhul pushed a commit to nerzhul/minetest that referenced this pull request Feb 7, 2017

Improve security for client-sided mods (minetest#5100)

29cd878

nerzhul pushed a commit that referenced this pull request Feb 8, 2017

Improve security for client-sided mods (#5100)

80b778c

nerzhul pushed a commit to nerzhul/minetest that referenced this pull request Mar 6, 2017

Improve security for client-sided mods (minetest#5100)

9a0ff3c

nerzhul pushed a commit that referenced this pull request Mar 13, 2017

Improve security for client-sided mods (#5100)

e9c73e2

nerzhul pushed a commit that referenced this pull request Mar 13, 2017

[CSM] Improve security for client-sided mods (#5100)

ad70395

nerzhul pushed a commit that referenced this pull request Mar 13, 2017

[CSM] Improve security for client-sided mods (#5100)

a50d07d

red-001 deleted the improve_security branch March 19, 2017 10:38

nerzhul added this to Done in Server-sent Client Side Modding Apr 29, 2017

paramat mentioned this pull request Jan 17, 2018

CSM PRs without 2 stated approvals #6924

Closed

paramat mentioned this pull request Jan 17, 2018

Require a clear description for non-trivial PRs #6923

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CSM] Improve security #5100

[CSM] Improve security #5100

red-001 commented Jan 22, 2017

nerzhul commented Jan 23, 2017

sfan5 Jan 23, 2017

red-001 Jan 23, 2017

sfan5 Jan 23, 2017

red-001 Jan 23, 2017

sapier Jan 23, 2017

rubenwardy Jan 23, 2017 •

edited

nerzhul Jan 23, 2017

rubenwardy Jan 23, 2017

sapier Jan 23, 2017

sapier Jan 23, 2017

sapier Jan 23, 2017

ShadowNinja commented Jan 24, 2017

nerzhul commented Jan 27, 2017

paramat commented Jan 17, 2018

[CSM] Improve security #5100

[CSM] Improve security #5100

Conversation

red-001 commented Jan 22, 2017

nerzhul commented Jan 23, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rubenwardy Jan 23, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ShadowNinja commented Jan 24, 2017

nerzhul commented Jan 27, 2017

paramat commented Jan 17, 2018

rubenwardy Jan 23, 2017 •

edited