Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lua API Documentation Cleanups #5269

Closed
wants to merge 3 commits into from

Conversation

rubenwardy
Copy link
Member

@rubenwardy rubenwardy commented Feb 18, 2017

The aim of the PR is to increase the readability of lua_api.txt, and to place everything into nicer sections

  • Add game dir structure docs
  • Put all mod and game info into their relevant sections
  • Remove incorrect mod location info
  • For registered id section, make main heading match contents (ie: aliases makes sense in a reg.id. section, but not in a naming conventions for reg.id. section)
  • Use list rather than headings for texture modifiers - increases readability imo, and is also more consistent
  • Put simple sound spec into definitions of simple things
  • Clean up nodes, paramtype, and draw type sections

@rubenwardy rubenwardy added @ Documentation WIP The PR is still being worked on by its author and not ready yet. labels Feb 18, 2017
@rubenwardy rubenwardy changed the title Lua api fixes Lua API Documentation Cleanups Feb 18, 2017
@@ -140,14 +152,13 @@ Mod directory structure
| |-- sounds
| |-- media
| `-- <custom data>
`-- another

`-- another`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list style should be changed a bit. I think this looks a bit strange in a graphical markdown view.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. It also breaks my highlighter. Maybe something like:

C:.
├───AdminScripts
├───iissamples
├───mailroot
│   ├───Badmail
│   ├───Drop
│   ├───Mailbox
│   ├───Pickup
│   ├───Queue
│   ├───Route
│   └───SortTemp
├───Scripts
└───wwwroot
    ├───aspnet_client
    │   └───system_web
    │       └───1_1_4322
    │           └───_vti_cnf
    ├───images
    ├───_private
    └───_vti_log

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Windows' tree output format is good but needs a space between the last dash and name.
Otherwise LGTM.
EDIT: http://dev.minetest.net/Installing_Mods#Example_structure

Copy link
Contributor

@paramat paramat Feb 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes please format in plain text as in comment above.

@paramat paramat added the Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements label Feb 18, 2017
@paramat
Copy link
Contributor

paramat commented Feb 19, 2017

Please focus on readability in .txt form, not MD graphical form. The file is viewed as .txt far more often than MD graphical.
Why is this document formatted for MD at all? It is viewed as normal text 99% of the time and the added MD symbols make it visually messy.
Please can we remove all MD format changes? that was a mistake.

@rubenwardy
Copy link
Member Author

Part of my changes is to try and make it easier to read - by removing pointless ` ticks, and using a list rather than annoying headings

@paramat
Copy link
Contributor

paramat commented Feb 19, 2017

Good, might as well remove all MD formatting then.

@rubenwardy
Copy link
Member Author

Nope, it's still useful to make it consistent and also allows HTML conversion

@paramat
Copy link
Contributor

paramat commented Feb 19, 2017

Ok, allowing to link to a section is useful, that should be kept of course.

@paramat
Copy link
Contributor

paramat commented Feb 19, 2017

Also, if we were not using 'pos' with angled quote marks we would be using 'pos' which is not much different, so that is ok too.
Looking at your modding book i think you're the ideal person to work on this.

@numberZero
Copy link
Contributor

numberZero commented Feb 19, 2017

looks nice. just don’t forget there is vim, it uses the markup too ;) (although it can’t recognize the file type automatically, needing :set filetype=markdown)

@rubenwardy rubenwardy added the Rebase needed The PR needs to be rebased by its author. label Aug 13, 2017
@rubenwardy
Copy link
Member Author

closing as heavily WIP, and probably needs restarting

@rubenwardy rubenwardy closed this Aug 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Documentation Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Rebase needed The PR needs to be rebased by its author. WIP The PR is still being worked on by its author and not ready yet.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants