New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lua API Documentation Cleanups #5269
Conversation
41d4e57
to
5a76c01
Compare
@@ -140,14 +152,13 @@ Mod directory structure | |||
| |-- sounds | |||
| |-- media | |||
| `-- <custom data> | |||
`-- another | |||
|
|||
`-- another` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list style should be changed a bit. I think this looks a bit strange in a graphical markdown view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. It also breaks my highlighter. Maybe something like:
C:.
├───AdminScripts
├───iissamples
├───mailroot
│ ├───Badmail
│ ├───Drop
│ ├───Mailbox
│ ├───Pickup
│ ├───Queue
│ ├───Route
│ └───SortTemp
├───Scripts
└───wwwroot
├───aspnet_client
│ └───system_web
│ └───1_1_4322
│ └───_vti_cnf
├───images
├───_private
└───_vti_log
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows' tree
output format is good but needs a space between the last dash and name.
Otherwise LGTM.
EDIT: http://dev.minetest.net/Installing_Mods#Example_structure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes please format in plain text as in comment above.
Please focus on readability in .txt form, not MD graphical form. The file is viewed as .txt far more often than MD graphical. |
Part of my changes is to try and make it easier to read - by removing pointless ` ticks, and using a list rather than annoying headings |
Good, might as well remove all MD formatting then. |
Nope, it's still useful to make it consistent and also allows HTML conversion |
Ok, allowing to link to a section is useful, that should be kept of course. |
Also, if we were not using 'pos' with angled quote marks we would be using 'pos' which is not much different, so that is ok too. |
looks nice. just don’t forget there is |
5a76c01
to
9532e8b
Compare
closing as heavily WIP, and probably needs restarting |
The aim of the PR is to increase the readability of lua_api.txt, and to place everything into nicer sections