Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please improve "failed to get schematic" errors #5376

Open
verymilan opened this issue Mar 11, 2017 · 7 comments
Open

Please improve "failed to get schematic" errors #5376

verymilan opened this issue Mar 11, 2017 · 7 comments
Labels
Concept approved Approved by a core dev: PRs welcomed! Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature. @ Script API

Comments

@verymilan
Copy link

Hi there, i host a little server for someone.
Somehow his server freezes after around 600MB place_schematic: failed to get schematic error messages.

So, this is a problem, we both have no idea what mod causes this trouble and i think the error message should at least print the schematic name which is called to make this easier.
Minetest is at commit eb49009.

kind Regards

@sofar
Copy link
Contributor

sofar commented Mar 12, 2017

the schematic isn't always a name. It could be a lua table, and that wouldn't have any identifiable information.

@paramat paramat added the Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature. label Mar 12, 2017
@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Mar 13, 2017

Well, then. Are there other ways to add more information to this error message? The intention of this issue is to make Minetest more debuggable, which is obviously needed.
So even some hints about where the schematic could come from would ease up debugging a lot.

Well, if the schematic does not have a name, then say it is a Lua table. If it has a name, print it.
If the schematic comes from a Lua table, say from which file it comes from. If I recall correctly, Lua is capable of introspection (with the debug table, but this may be a danger zone).

Besides, the error message itself is also pretty cryptic on its own. It is not clear what exactly is meant with “getting” a schematic, and why it “failed”. Did a file loading fail (then mention the attempted file name)? Had the schematic a bad syntax? Is the function called place_schematic or minetest.place_schematic? Was something nil / NULL? And so on.

@paramat paramat added Possible close and removed Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature. labels Sep 8, 2017
@paramat
Copy link
Contributor

paramat commented Sep 8, 2017

This needs more information, the full error message or better a backtrace with using gdb maybe in debug mode. Otherwise we can't help. Closing in 1 month.

@rubenwardy
Copy link
Member

paramat, this is a request for more debugging info not reporting a bug

@sfan5 sfan5 added @ Script API Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature. and removed Possible close labels Sep 8, 2017
@paramat
Copy link
Contributor

paramat commented Sep 8, 2017

Yes, misunderstood.

@paramat
Copy link
Contributor

paramat commented Sep 22, 2018

1+ year bump. Any core dev support?

@SmallJoker
Copy link
Member

@paramat Yes. This output needs improvement.

@paramat paramat added the Concept approved Approved by a core dev: PRs welcomed! label Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Concept approved Approved by a core dev: PRs welcomed! Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature. @ Script API
Projects
None yet
Development

No branches or pull requests

7 participants