clang-format: add a whitelist #5459
Conversation
nerzhul
added
the
@ Build
nerzhul
force-pushed
the
clang_format_whitelist
branch
from
c28406f
to
373a9f4
Compare
|
Soft fail test commit: https://travis-ci.org/minetest/minetest/builds/215263717 => https://travis-ci.org/minetest/minetest/jobs/215263724 |
|
When approval will be added i will remove the two test commits and merge the first commit |
|
wouldn't it be easier to have a blacklist? |
|
what do you want to blacklist ? the currently valid files ? it's better to dynamicly have every file checked and whitelist non formatted files, and after a file is valid, remove it from whitelist, and at the end, remove blacklist/whitelist support. |
util/travis/script.sh
Outdated
| whitelisted=$(egrep -c "^${f}" "${CLANG_FORMAT_WHITELIST}") | ||
|
|
||
| # If no failure recorded and file is not whitelisted, mark a failure | ||
| if [ ${fail} -eq 0 ] && [ ${whitelisted} -eq 0 ]; then |
There was a problem hiding this comment.
the ${fail} -eq 0 is very confusing here as it doesn't actually matter
|
Nevermind it's okay like this |
If file is in the whitelist, softfail, else hard failure Some files are not in whitelist and marked as normal: * src/content_mapnode.h * src/cguittfont/xCGUITTFont.cpp * src/gameparams.h * src/profiler.cpp
nerzhul
force-pushed
the
clang_format_whitelist
branch
from
f6b736c
to
e661a76
Compare
If file is in the whitelist, softfail, else hard failure
Some files are not in whitelist and marked as normal: