Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix no sound bug #5968

Merged
merged 1 commit into from Jun 14, 2017
Merged

Fix no sound bug #5968

merged 1 commit into from Jun 14, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2017 •
edited by ghost

@ghost ghost mentioned this pull request Jun 12, 2017
Closed
@ghost
Copy link
Author

ghost commented Jun 12, 2017

@Fixer-007

@sfan5 sfan5 added the Bugfix 🐛 PRs that fix a bug label Jun 12, 2017
@Fixer-007
Copy link
Contributor

Fixer-007 commented Jun 12, 2017 •
edited

Does not fix much, results of testing on various servers:
singleplayer - no problem
0.4.14 - no problem
0.4.15 - no problem
0.4.16 - problem
0.4.16-dev - some servers ok (Hometown), some not (Vanessa's servers).

@ghost
Copy link
Author

ghost commented Jun 12, 2017

Updated.

nerzhul
nerzhul reviewed Jun 12, 2017
View reviewed changes
src/itemdef.cpp Outdated
@@ -167,7 +170,7 @@ void ItemDefinition::deSerialize(std::istream &is)

// Deserialize
int version = readU8(is);
if(version < 1 || version > 3)
if(version < 1 || version > 4)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing space

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@nerzhul
Copy link
Member

nerzhul commented Jun 12, 2017

@Fixer-007 can you re-test it ?

@Fixer-007
Copy link
Contributor

Fixer-007 commented Jun 12, 2017 •
edited

New results. Tested by digging/placing torch, solid blocks, walking:
singleplayer - no problem
0.4.14-dev - no problem (JT 2)
0.4.15 - no problem (BuildersWorld)
0.4.15-dev - no problem (Dark Lands)
0.4.16 - no problem (Jungle, Liberty Land)
0.4.16-dev - no problem (Hometown, Vanessa)

Seems fine.

@paramat paramat added the Sounds label Jun 13, 2017
@ghost
Copy link
Author

ghost commented Jun 14, 2017

Waiting for approval.

@nerzhul nerzhul merged commit bbe3dd9 into minetest:master Jun 14, 2017
@paramat
Copy link
Contributor

paramat commented Jun 16, 2017 •
edited

Sorry, i should not have approved this, i don't understand the issue and implementation enough to do so.
This seems to have caused a bug #5991

osjc pushed a commit to osjc/minetest that referenced this pull request Jan 11, 2019
@osjc
Fix no sound bug (minetest#5968)
2ae2bcb
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 23, 2019
@osjc
Fix no sound bug (minetest#5968)
c626066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug One approval ✅ ◻️ Sounds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Fixer-007 @nerzhul @paramat @sfan5