C++11 cleanup on constructors #6000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dumbeldor
force-pushed
the
cpp11_initialisers
branch
from
a8cd47d
to
50cec19
Compare
nerzhul
requested changes
Jun 17, 2017
src/script/cpp_api/s_base.cpp
Outdated
| @@ -72,8 +72,7 @@ class ModNameStorer | |||
| */ | |||
|
|
|||
| ScriptApiBase::ScriptApiBase() : | |||
| m_luastackmutex(), | |||
| m_gamedef(NULL) | |||
| m_luastackmutex() | |||
There was a problem hiding this comment.
this constructor is useless you can remove it
nerzhul
added
the
Maintenance
Dumbeldor
changed the title
nerzhul
requested changes
Jun 18, 2017
nerzhul
approved these changes
Jun 18, 2017
|
@Zeno- @SmallJoker can you take a look ? |
SmallJoker
reviewed
Jun 19, 2017
src/script/lua_api/l_areastore.h
Outdated
| @@ -49,7 +49,7 @@ class LuaAreaStore : public ModApiBase | |||
| static int l_from_file(lua_State *L); | |||
|
|
|||
| public: | |||
| AreaStore *as; | |||
| AreaStore *m_as = nullptr; | |||
There was a problem hiding this comment.
m_ prefix is used for private members. Revert to as or areastore.
SmallJoker
approved these changes
Jun 19, 2017
nerzhul
reviewed
Jun 19, 2017
src/threading/event.cpp
Outdated
| @@ -32,7 +32,6 @@ void Event::wait() | |||
| while (!notified) { | |||
| cv.wait(lock); | |||
| } | |||
| notified = false; | |||
Dumbeldor
force-pushed
the
cpp11_initialisers
branch
from
0f7f305
to
ad080c3
Compare
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 11, 2019
* C++11 cleanup on constructors dir script
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
* C++11 cleanup on constructors dir script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.