C++11 cleanup on constructors dir network #6021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dumbeldor
commented
Jun 20, 2017
| @@ -2031,8 +1981,7 @@ void ConnectionSendThread::sendAsPacket(u16 peer_id, u8 channelnum, | |||
| } | |||
|
|
|||
| ConnectionReceiveThread::ConnectionReceiveThread(unsigned int max_packet_size) : | |||
There was a problem hiding this comment.
max_packet_size isn't used, I remove it or can it be used in the near future?
nerzhul
added
the
Maintenance
nerzhul
requested changes
Jun 20, 2017
src/network/connection.h
Outdated
| @@ -625,7 +628,7 @@ class PeerHelper | |||
| bool operator!=(void* ptr); | |||
|
|
|||
| private: | |||
| Peer* m_peer; | |||
| Peer* m_peer = 0; | |||
There was a problem hiding this comment.
nullptr & check if NULL is tested on this variable
src/network/connection.h
Outdated
| @@ -758,16 +748,21 @@ class Peer { | |||
| float min_rtt; | |||
| float max_rtt; | |||
| float avg_rtt; | |||
|
|
|||
| rttstats(float jitter_min_ = FLT_MAX, float jitter_max_ = 0.0f, float jitter_avg_ = -1.0f, | |||
nerzhul
reviewed
Jun 20, 2017
src/network/connection.cpp
Outdated
| @@ -812,7 +812,7 @@ void Channel::UpdateTimers(float dtime,bool legacy_peer) | |||
| PeerHelper::PeerHelper(Peer* peer) : | |||
| m_peer(peer) | |||
| { | |||
| if (peer != NULL) | |||
| if (peer) | |||
| { | |||
|
👍 pending braces being fixed |
nerzhul
approved these changes
Jun 21, 2017
nerzhul
approved these changes
Jun 21, 2017
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 11, 2019
* C++11 cleanup on constructors dir network
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
* C++11 cleanup on constructors dir network
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.