MSVC: Dont define min/max macros in minwindef.h #6308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerzhul
added
the
@ Build
|
if i works on mingw i will merge it, it's okay for me, trivial |
nerzhul
added
the
Trivial
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 11, 2019
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cant tell if this was introduced due to the latest Visual Studio update, or if this was caused by the cleanups of @nerzhul .
In minwindef.h (included by Windows.h) are macros defined for
minandmaxthat conflicting withstd::min/std::maxsince today. DefiningNOMINMAXdisables the definition of them.