Give subgames the ability to disallow specific mapgens #6792
Conversation
|
Will test. I support the concept. |
|
Thank you. Also please let me know if there is anywhere suitable to document this (other than wiki). It feels like it needs documentation, but none of the docs I see are suitable. |
| @@ -551,7 +551,7 @@ end | |||
| -------------------------------------------------------------------------------- | |||
| if INIT == "mainmenu" then | |||
| function core.get_game(index) | |||
| local games = game.get_games() | |||
| local games = core.get_games() | |||
There was a problem hiding this comment.
Interesting, was this a bug?
|
Documentation could be here https://github.com/minetest/minetest/blob/master/doc/lua_api.txt#L56 |
|
Added documentation. |
|
Works well 👍 |
| local gamepath = minetest.get_game(gameidx).path | ||
| local gameconfig = Settings(gamepath.."/game.conf") | ||
|
|
||
| local disallowed_mapgens = gameconfig:get("disallowed_mapgens") |
There was a problem hiding this comment.
local disallowed_mapgens = gameconfig:get("disallowed_mapgens"):lower():split()
for key, value in pairs(disallowed_mapgens) do
disallowed_mapgens[key] = value:trim()
end|
|
||
| if disallowed_mapgens then | ||
| for i = #mapgens, 1, -1 do | ||
| if string.find(disallowed_mapgens, mapgens[i]) then |
There was a problem hiding this comment.
if table.indexof(disallowed, mapgens[i]:lower()) > 0 then
|
Changing the subgame resets the text fields |
|
Worldname fixed and no longer resets incorrcetly, thank you. Seed already saves correctly so shouldn't need any adjustment. |
rubenwardy
added
>= Two approvals ✅ ✅
One approval ✅ ◻️
and removed
One approval ✅ ◻️
>= Two approvals ✅ ✅
labels
|
@paramat: still ok with this? |
|
This is a nice feature to have for modders to use. |
| disallowed_mapgens[key] = value:trim() | ||
| end | ||
|
|
||
| if disallowed_mapgens then |
There was a problem hiding this comment.
Superfluous check. string.split never returns nil.
There was a problem hiding this comment.
rubenwardy requested it be this way. I know his commented version is a little different, but he asked me to adjust to this, so will see what he says.
There was a problem hiding this comment.
I didn't notice this aha, krock is right unfortunately. But doesn't matter too much
| end | ||
| end | ||
|
|
||
| local gamepath = minetest.get_game(gameidx).path |
|
Just to note: When you've had three approvals... and are still getting asked to change things on something that works and isn't controversial, there is something a bit unappealing with the development process. |
|
@Ezhh Whereas the labels suggest the PR is not reviewed entirely yet - it apparently is. As you can see, the changes I requested are quite trivial and not required to make this PR work properly, they were requested for consistent and simple code. |
|
@SmallJoker I will be changing the other point you've raised, so hold on for that please. I simply don't want to change things that are already changes specifically asked for by developers without them weighing in again. I do understand how this works, but I also feel justified in being frustrated by it. |
|
Wow, so this was coded, tested and merged and I only noticed it now? xD Thanks, man! ❤️ |
|
@Wuzzy2 Very welcome. Hope it will be useful :) |
|
🎉 |
|
Yes i'm still fine with it. The other devs are better with menu code than i am. |
This allows a subgame to control which mapgens show in the Mapgen dropdown when making a new game/world.
Mapgens which are not supported or otherwise suitable for a given subgame can be disallowed by adding a setting in game.conf. For example, if you wish to disable v6, flat and fractal mapgens, add:
disallowed_mapgens = v6,flat,fractal
This results in:
Fixes #4768