Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mip mapping uses an incorrect downscaling algorithm #6867

Closed
HybridDog opened this issue Jan 1, 2018 · 4 comments
Closed

Mip mapping uses an incorrect downscaling algorithm #6867

HybridDog opened this issue Jan 1, 2018 · 4 comments
Labels
Bug Issues that were confirmed to be a bug @ Client / Audiovisuals Duplicate

Comments

@HybridDog
Copy link
Contributor

HybridDog commented Jan 1, 2018

missing gamma correction: http://www.ericbrasseur.org/gamma.html?i=1
on mipmaps: https://paroj.github.io/gltut/Texturing/Tut16%20Mipmaps%20and%20Linearity.html
I noticed that mipmapping ignores gamma when downscaling, you can test it by using the gamma dalai lama as some texture:
screenshot_20180101_183548
Note that you likely need to watch the image in 1:1 size because browsers also use incorrect downscaling.

Here's another example where you can see the impact: A black white chess board pattern looks (and is) brighter than the texture downscaled by the mipmapping algorithm:
screenshot_20180101_184206
Please take care to view this screenshot in 1:1, too.

@paramat paramat added @ Client / Audiovisuals Bug Issues that were confirmed to be a bug Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature. and removed Bug Issues that were confirmed to be a bug Request / Suggestion The issue makes a suggestion for something that should be done but isn't a new feature. labels Jan 4, 2018
@numberZero
Copy link
Contributor

Correctly, gamma should be applied after rendering (or as last operation in fragment shader). But currently it is effectively applied on meshgen, that is, on a per-vertex basis.

@SmallJoker
Copy link
Member

@HybridDog How is this issue different to #6846? Both are reporting the suboptimal mipmap downscaling algorithm.

@HybridDog
Copy link
Contributor Author

HybridDog commented Mar 8, 2018

This issue is about missing gamma correction and the other one is about the alpha channel problem.

Both are reporting the suboptimal mipmap downscaling algorithm.

l think so, too.

@HybridDog HybridDog changed the title Mipmapping uses an incorrect downscaling algorithm Mip mapping uses an incorrect downscaling algorithm Jul 13, 2018
@paramat
Copy link
Contributor

paramat commented Jul 14, 2018

Duplicate of #6846

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Issues that were confirmed to be a bug @ Client / Audiovisuals Duplicate
Projects
None yet
Development

No branches or pull requests

4 participants