Fix off-by-one in log output line length #6896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a log line is over 255 characters, only the first 255 were printed, and the next line would start in the 257th, hence skipping one.
red-001
approved these changes
Jan 8, 2018
|
@pgimeno Removing the local variable is a good idea, as it will make the code shorter and easier to understand. The bugfix alone looks good. |
|
I'd prefer the local variable to removed, as it's pointless |
rubenwardy
approved these changes
Jan 8, 2018
SmallJoker
approved these changes
Jan 9, 2018
ghost
deleted the
t0ny2
pushed a commit
to t0ny2/minetest
that referenced
this pull request
Jan 23, 2018
sfan5
pushed a commit
that referenced
this pull request
Feb 3, 2018
Closed
sfan5
pushed a commit
that referenced
this pull request
Apr 21, 2018
sfan5
pushed a commit
that referenced
this pull request
May 13, 2018
SmallJoker
pushed a commit
that referenced
this pull request
Jun 3, 2018
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 11, 2019
osjc
pushed a commit
to osjc/minetest
that referenced
this pull request
Jan 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a log line is over 255 characters, only the first 255 were printed, and the next line would start in the 257th, hence skipping one.
I'd rather get rid of the local, though, which I find distracting and prone to bugs like this one.