Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for /shutdown don't doing the countdown when using reconnect and/or shutdown message #7055

Merged
merged 1 commit into from Feb 19, 2018

Conversation

dopik
Copy link
Contributor

@dopik dopik commented Feb 18, 2018

Delay was converted from the param string and not the delay value, thus never using the actual given delay value when used in combination with other string values in the param, in this case reconnect and the shutdown messsage.

…sage

Delay was converted from the param string and not the delay value, thus never using the actual given delay value when used in combination with other string values in the param, in this case reconnect and the shutdown messsage.
@dopik dopik changed the title /shutdown can't do countdown when using reconnect and/or shutdown mes… Fix for /shutdown don't doing the countdown when using reconnect and/or shutdown message Feb 18, 2018
@nerzhul nerzhul added the Bugfix 🐛 PRs that fix a bug label Feb 18, 2018
Copy link
Member

@nerzhul nerzhul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay for me, thanks

@paramat
Copy link
Contributor

paramat commented Feb 19, 2018

👍

@nerzhul nerzhul merged commit cf98f5b into minetest:master Feb 19, 2018
minduser00 pushed a commit to minduser00/minetest that referenced this pull request Mar 18, 2018
…sage (minetest#7055)

Delay was converted from the param string and not the delay value, thus never using the actual given delay value when used in combination with other string values in the param, in this case reconnect and the shutdown messsage.
minduser00 pushed a commit to minduser00/minetest that referenced this pull request Mar 18, 2018
…sage (minetest#7055)

Delay was converted from the param string and not the delay value, thus never using the actual given delay value when used in combination with other string values in the param, in this case reconnect and the shutdown messsage.
sfan5 pushed a commit that referenced this pull request Apr 21, 2018
…sage (#7055)

Delay was converted from the param string and not the delay value, thus never using the actual given delay value when used in combination with other string values in the param, in this case reconnect and the shutdown messsage.
@sfan5 sfan5 mentioned this pull request Apr 21, 2018
sfan5 pushed a commit that referenced this pull request May 13, 2018
…sage (#7055)

Delay was converted from the param string and not the delay value, thus never using the actual given delay value when used in combination with other string values in the param, in this case reconnect and the shutdown messsage.
sfan5 pushed a commit that referenced this pull request May 13, 2018
…sage (#7055)

Delay was converted from the param string and not the delay value, thus never using the actual given delay value when used in combination with other string values in the param, in this case reconnect and the shutdown messsage.
SmallJoker pushed a commit that referenced this pull request Jun 3, 2018
…sage (#7055)

Delay was converted from the param string and not the delay value, thus never using the actual given delay value when used in combination with other string values in the param, in this case reconnect and the shutdown messsage.
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 23, 2019
…sage (minetest#7055)

Delay was converted from the param string and not the delay value, thus never using the actual given delay value when used in combination with other string values in the param, in this case reconnect and the shutdown messsage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants