New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cavegen: Fix variable typo that broke mgvalleys large cave distribution #7249
Conversation
This fix was made to
But wasn't done in the general large caves code The error has actually been present since 03868ff April 2013 Line 948 in f85c116
Line 1001 in f85c116
|
Mgv7 tested and fine. |
Fix elusive 5 year old bug that caused mgvalleys large caves to be flat and limited to mapchunk borders. Error was fixed 2 years ago in 'CavesV6' but not in 'CavesRandomWalk'.
Updated to remove unused variable from header file. |
…on (#7249) Fix elusive 5 year old bug that caused mgvalleys large caves to be flat and limited to mapchunk borders. Error was fixed 2 years ago in 'CavesV6' but not in 'CavesRandomWalk'.
…on (#7249) Fix elusive 5 year old bug that caused mgvalleys large caves to be flat and limited to mapchunk borders. Error was fixed 2 years ago in 'CavesV6' but not in 'CavesRandomWalk'.
…on (#7249) Fix elusive 5 year old bug that caused mgvalleys large caves to be flat and limited to mapchunk borders. Error was fixed 2 years ago in 'CavesV6' but not in 'CavesRandomWalk'.
…on (minetest#7249) Fix elusive 5 year old bug that caused mgvalleys large caves to be flat and limited to mapchunk borders. Error was fixed 2 years ago in 'CavesV6' but not in 'CavesRandomWalk'.
Fixes #7244 (comment)
'max_stone_y' did not match the function argument 'max_stone_height', see the same line in
CavesV6::makeCave()
which does match the function argument:minetest/src/mapgen/cavegen.cpp
Line 676 in 574dab5
max_stone_y
still worked and didn't cause a compile error somehow, maybe because it is present here:minetest/src/mapgen/cavegen.h
Line 137 in 574dab5
And here:
minetest/src/mapgen/mapgen.cpp
Line 827 in 574dab5
So mgvalleys large caves were broken all this time.