Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biome-defined cave liquids: Use faster biome calculation #7282

Closed
wants to merge 1 commit into from
Closed

Biome-defined cave liquids: Use faster biome calculation #7282

wants to merge 1 commit into from

Conversation

paramat
Copy link
Contributor

@paramat paramat commented Apr 26, 2018

screenshot_20180426_131807

Fixes mistake in 32d456b
'calcBiomeAtPoint()' calculates the heat and humidity noises, but we already have those calculated and stored in the noise perlinmaps, so use 'getBiomeAtPoint()' instead which gets the noise values from the perlinmaps.
Improves performance.
A similar PR for the same mistake in biome-defined dungeon nodes is coming soon.
Tested.

@paramat paramat added @ Mapgen Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines Bugfix 🐛 PRs that fix a bug Performance labels Apr 26, 2018
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

@SmallJoker
Copy link
Member

bb3baef

@SmallJoker SmallJoker closed this Apr 26, 2018
@paramat
Copy link
Contributor Author

paramat commented Apr 26, 2018

Thanks for merging.

@paramat paramat deleted the fixcaveliqgetbiome branch May 1, 2018 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug @ Mapgen One approval ✅ ◻️ Performance Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants