Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Plantlike_rooted' drawtype black when smooth lighting disabled #7345

Closed
paramat opened this issue May 17, 2018 · 6 comments
Closed

'Plantlike_rooted' drawtype black when smooth lighting disabled #7345

paramat opened this issue May 17, 2018 · 6 comments
Labels
@ Client / Audiovisuals Not a bug The behaviour is working as intended and won't be changed.
Milestone

Comments

@paramat
Copy link
Contributor

paramat commented May 17, 2018

screenshot_20180515_235158

minetest.register_node("default:sand_with_kelp", {
	description = "Kelp",
	drawtype = "plantlike_rooted",
	waving = 1,
	tiles = {"default_sand.png"},
	special_tiles = {{name = "default_kelp.png", tileable_vertical = true}},
	inventory_image = "default_kelp.png",
	paramtype2 = "leveled",
	groups = {snappy = 3},
	selection_box = {
		type = "fixed",
		fixed = {
				{-0.5, -0.5, -0.5, 0.5, 0.5, 0.5},
				{-2/16, 0.5, -2/16, 2/16, 3.5, 2/16},
		},
	},
	node_dig_prediction = "default:sand",
	node_placement_prediction = "",
@paramat paramat added Bug Issues that were confirmed to be a bug @ Client / Audiovisuals labels May 17, 2018
@paramat paramat added this to the 0.5.0 milestone May 17, 2018
@paramat paramat added the Blocker The issue needs to be addressed before the next release. label May 17, 2018
@SmallJoker SmallJoker removed the Blocker The issue needs to be addressed before the next release. label May 17, 2018
@HybridDog
Copy link
Contributor

HybridDog commented May 18, 2018

You didn't explicitly set paramtype to "light", is this is required for the "plantlike_rooted" drawtype? (lua_api doesn't mention when to use paramtype "light" as far as l can see)
(for reference, you declined a PR to set such values implicitly #6246)

@paramat
Copy link
Contributor Author

paramat commented May 18, 2018

Not sure if it is required, will try.
(Yes declined for good reason).

@paramat paramat added Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible Question Not a bug The behaviour is working as intended and won't be changed. and removed Bug Issues that were confirmed to be a bug Unconfirmed bug Bug report that has not been confirmed to exist/be reproducible labels May 19, 2018
@paramat
Copy link
Contributor Author

paramat commented May 19, 2018

HybridDog thanks that solves it, the plantlike extension probably takes it's light level from the internal value. Will fix in MTG soon.

@HybridDog
Copy link
Contributor

HybridDog commented May 19, 2018

I still think lua_api should mention that specific drawtypes require paramtype "light".
Here's a list of them (Aug 2017): https://github.com/minetest/minetest/pull/6246/files#diff-7b4242351dd3cf5b2a70c8aa9d12149bR108

@paramat
Copy link
Contributor Author

paramat commented May 19, 2018

I agree it should be in docs, i updated drawtype docs recently but didn't add that information.

@numberZero
Copy link
Contributor

numberZero commented May 20, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@ Client / Audiovisuals Not a bug The behaviour is working as intended and won't be changed.
Projects
None yet
Development

No branches or pull requests

4 participants