Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename some keys for clarity #7384

Merged
merged 1 commit into from May 29, 2018
Merged

Rename some keys for clarity #7384

merged 1 commit into from May 29, 2018

Conversation

Wuzzy2
Copy link
Contributor

@Wuzzy2 Wuzzy2 commented May 29, 2018 •
edited

The following keys get renamed:

  • “Back” → “Backspace”
  • “Prior” → “Page up”
  • “Next” → “Page down”

These have been tested in-game.

Note the string “Back” is currently also used in the mod storage for a back button, causing a string collision. This PR fixes that as well.

@SmallJoker SmallJoker added Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines @ Client / Controls / Input labels May 29, 2018
@paramat
Copy link
Contributor

paramat commented May 29, 2018

👍

@SmallJoker SmallJoker merged commit 19df59f into minetest:master May 29, 2018
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 23, 2019
@Wuzzy2 @osjc
Rename some keys for clarity (minetest#7384)
8b004eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
@ Client / Controls / Input One approval ✅ ◻️ Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Wuzzy2 @paramat @SmallJoker