Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ContentDB: Update API #7459

Merged
merged 2 commits into from Jun 18, 2018
Merged

ContentDB: Update API #7459

merged 2 commits into from Jun 18, 2018

Conversation

rubenwardy
Copy link
Member

No description provided.

SmallJoker
SmallJoker approved these changes Jun 18, 2018
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but didn't test.

@SmallJoker SmallJoker changed the title Contentnewapi ContentDB: Update API Jun 18, 2018
@rubenwardy rubenwardy merged commit ca502fc into minetest:master Jun 18, 2018
nerzhul
nerzhul reviewed Jun 18, 2018
View reviewed changes
src/script/lua_api/l_mainmenu.cpp
lua_pushstring(L, package.screenshots[i].c_str());
lua_settable(L, top_screenshots);
}
if (package.thumbnail != "") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!package.thumnail.empty()

@rubenwardy rubenwardy deleted the contentnewapi branch June 18, 2018 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerzhul nerzhul nerzhul left review comments

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
@ Mainmenu One approval ✅ ◻️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rubenwardy @nerzhul @SmallJoker