Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android buttons: Inset 'rare controls', inset and resize 'gear icon' #7792

Merged
merged 1 commit into from Oct 19, 2018
Merged

Android buttons: Inset 'rare controls', inset and resize 'gear icon' #7792

merged 1 commit into from Oct 19, 2018

Conversation

paramat
Copy link
Contributor

@paramat paramat commented Oct 17, 2018

Previously these were both inconsistently close to the screen edge.
'gear icon' has been enlarged to match the width of 'zoom' and 'aux'
buttons.
/////////////////////////////

I can't test this so no screenshot.

whatsapp image 2018-10-15 at 20 46 38 5

^ MT master

Previously these 2 buttons were too close to screen edge, inconsistent with other buttons and might be problematic when using a case. This PR also cleans up horrible codestyle.
Any testing welcome.

@paramat paramat added Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements Android @ Client / Controls / Input Testing needed labels Oct 17, 2018
@paramat paramat added this to the 5.0.0 milestone Oct 17, 2018
@stujones11
Copy link
Contributor

stujones11 commented Oct 17, 2018

Looks okay for me

screen
Ignore the git-hash, I just applied the change to an existing build.

@SmallJoker
Copy link
Member

That's now already much easier to use. To make it look a bit better, center the "rare controls" button so that it's on the same vertical line as the zoom and aux buttons.

@stujones11
Copy link
Contributor

stujones11 commented Oct 17, 2018

To make it look a bit better, center the "rare controls" button

I personally think the gear icon is too small compared to the other buttons. I would suggest that by increasing the size, it would naturally have the correct alignment.

@paramat
Copy link
Contributor Author

paramat commented Oct 18, 2018

Thanks for testing. The gear icon has no space around it in the texture frame https://github.com/minetest/minetest/blob/master/textures/base/pack/gear_icon.png so it will still need indenting.
I'll enlarge it to match the zoom and AUX buttons in width.

I'd rather not move the rare controls button in any further as it would intrude too much on the joystick. Also, all buttons have their outer edges aligned, not their centres.

@paramat paramat added the WIP The PR is still being worked on by its author and not ready yet. label Oct 18, 2018
@paramat paramat changed the title Android controls: Inset 'rare controls' and 'gear' buttons Android buttons: Inset 'rare controls', inset and resize 'gear icon' Oct 18, 2018
@paramat paramat removed the WIP The PR is still being worked on by its author and not ready yet. label Oct 18, 2018
@paramat
Copy link
Contributor Author

paramat commented Oct 18, 2018

Updated.

The gear icon texture has changed from 64x128 to 128x128, so the X insets of each side from screen edge are now (1.25 * button_size) and (0.25 * button_size) just like 'zoom' and 'aux'.
The gear image itself has been enlarged to be equal in width to the 'zoom' magnifying glass image.
As explained above i have left 'rare controls' as it is.

Any retesting much appreciated.

Previously these were both inconsistently close to the screen edge.
'gear icon' has been enlarged to match the width of 'zoom' and 'aux'
buttons.
@stujones11
Copy link
Contributor

Here's how it looks now

screen

LGTM 👍

@paramat
Copy link
Contributor Author

paramat commented Oct 19, 2018

Thanks for testing.

@paramat paramat merged commit e369eb1 into minetest:master Oct 19, 2018
@paramat paramat deleted the androidgear branch October 20, 2018 06:29
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 23, 2019
…inetest#7792)

Previously these were both inconsistently close to the screen edge.
'gear icon' has been enlarged to match the width of 'zoom' and 'aux'
buttons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android @ Client / Controls / Input Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants