New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android buttons: Inset 'rare controls', inset and resize 'gear icon' #7792
Conversation
That's now already much easier to use. To make it look a bit better, center the "rare controls" button so that it's on the same vertical line as the zoom and aux buttons. |
I personally think the gear icon is too small compared to the other buttons. I would suggest that by increasing the size, it would naturally have the correct alignment. |
Thanks for testing. The gear icon has no space around it in the texture frame https://github.com/minetest/minetest/blob/master/textures/base/pack/gear_icon.png so it will still need indenting. I'd rather not move the rare controls button in any further as it would intrude too much on the joystick. Also, all buttons have their outer edges aligned, not their centres. |
Updated. The gear icon texture has changed from 64x128 to 128x128, so the X insets of each side from screen edge are now (1.25 * button_size) and (0.25 * button_size) just like 'zoom' and 'aux'. Any retesting much appreciated. |
Previously these were both inconsistently close to the screen edge. 'gear icon' has been enlarged to match the width of 'zoom' and 'aux' buttons.
Thanks for testing. |
…inetest#7792) Previously these were both inconsistently close to the screen edge. 'gear icon' has been enlarged to match the width of 'zoom' and 'aux' buttons.
Previously these were both inconsistently close to the screen edge.
'gear icon' has been enlarged to match the width of 'zoom' and 'aux'
buttons.
/////////////////////////////
I can't test this so no screenshot.
^ MT master
Previously these 2 buttons were too close to screen edge, inconsistent with other buttons and might be problematic when using a case. This PR also cleans up horrible codestyle.
Any testing welcome.