Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotation marks in flags settings #7844

Merged
merged 1 commit into from Nov 9, 2018

Conversation

srifqi
Copy link
Member

@srifqi srifqi commented Nov 8, 2018

The quotation marks make the flags cannot be read. Removing it fixes #7776.

Before:

# mgv7_np_floatland_base = {
#    offset      = -0.6,
#    scale       = 1.5,
#    spread      = (600, 600, 600),
#    seed        = 114,
#    octaves     = 5,
#    persistence = 0.6,
#    lacunarity  = 2.0,
#    flags       = "eased"
# }

After:

# mgv7_np_floatland_base = {
#    offset      = -0.6,
#    scale       = 1.5,
#    spread      = (600, 600, 600),
#    seed        = 114,
#    octaves     = 5,
#    persistence = 0.6,
#    lacunarity  = 2.0,
#    flags       = eased
# }

@paramat paramat self-assigned this Nov 8, 2018
@paramat
Copy link
Contributor

paramat commented Nov 8, 2018

Thanks will test.

@paramat paramat added Blocker The issue needs to be addressed before the next release. High priority labels Nov 8, 2018
@paramat paramat added this to the 5.0.0 milestone Nov 8, 2018
@paramat paramat removed the Blocker The issue needs to be addressed before the next release. label Nov 8, 2018
@paramat
Copy link
Contributor

paramat commented Nov 8, 2018

Tested, if i add in .conf:

mgv7_np_floatland_base = {
   offset      = -0.4,
   scale       = 1.4,
   spread      = (600, 600, 600),
   seed        = 114,
   octaves     = 5,
   persistence = 0.6,
   lacunarity  = 2.0,
   flags       = eased
}

Then the mapgen result is now correctly eased noise, and the entry in map_meta.txt is:

mgv7_np_floatland_base = {
	lacunarity = 2
	persistence = 0.6
	octaves = 5
	offset = -0.4
	scale = 1.4
	flags = eased
	spread = (600,600,600)
	seed = 114
}

👍

@paramat paramat added @ Mapgen Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines One approval ✅ ◻️ labels Nov 8, 2018
@paramat paramat merged commit 57a2f3e into minetest:master Nov 9, 2018
@srifqi srifqi deleted the remove_quote_flags branch February 17, 2019 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix 🐛 PRs that fix a bug High priority @ Mapgen One approval ✅ ◻️ @ Startup / Config / Util Trivial The change is a trivial bug fix, documentation or maintenance change, as per the Git Guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting of noise flags broken in.conf and advanced settings
3 participants