New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Main menu style: Set to 'full' for Android, remove 'auto' option #7936
Conversation
While I agree that additional worlds and sub game selection should be possible on mobile devices, I think this is an over-simplistic solution. Since the gui scaling improvements, the full menu is indeed useable but game header is truncated and pushed behind the form. Also note that the game selection bar Correction: The game selection bar is in lua except it uses the I would personally favour keeping the simple menu for mobile, except include an additional tab for game and world selection. At the very least, I think we need to do something about the background image. |
I suggest removing the game selection bar on Android, and flipping the "start game" form to have the list and 3 buttons on the left, and checks on the right |
Unfortunately this would be harder than I expected, due to the fields added by host server
I've done the first section though, in #7940. It also hides the header |
In that case I don't see a problem with this 👍 |
The simple menus for Android add a lot of code though, better to remove that and have PC and Android being as similar as possible. |
WIP as this might as well include the removal of simple menu code also, otherwise i'll just have to work on this code again soon. |
Actually not WIP. I can remove simple menu code in a separate PR (probably best). |
Initial work for #2600
See comments of support #2600 (comment) and #2600 (comment)
I can also remove simple menu code if or when full menu is confirmed ok for all Android devices.