Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main menu style: Set to 'full' for Android, remove 'auto' option #7936

Merged
merged 1 commit into from Dec 6, 2018
Merged

Main menu style: Set to 'full' for Android, remove 'auto' option #7936

merged 1 commit into from Dec 6, 2018

Conversation

paramat
Copy link
Contributor

@paramat paramat commented Dec 3, 2018

Initial work for #2600
See comments of support #2600 (comment) and #2600 (comment)
I can also remove simple menu code if or when full menu is confirmed ok for all Android devices.

@paramat paramat added Blocker The issue needs to be addressed before the next release. Android High priority labels Dec 3, 2018
@paramat paramat added this to the 5.0.0 milestone Dec 3, 2018
@stujones11
Copy link
Contributor

stujones11 commented Dec 4, 2018

While I agree that additional worlds and sub game selection should be possible on mobile devices, I think this is an over-simplistic solution. Since the gui scaling improvements, the full menu is indeed useable but game header is truncated and pushed behind the form.

Also note that the game selection bar is not part of the lua main menu so does not get compensated for scale. It does, however just fit on my screen which is pretty wide aspect 2:1

Correction: The game selection bar is in lua except it uses the box[] formspec element. I am not exactly sure how this one sits with the current formspec scaling method, it seems they can be outside of the parent form bounds. :?

screen

I would personally favour keeping the simple menu for mobile, except include an additional tab for game and world selection. At the very least, I think we need to do something about the background image.

@rubenwardy
Copy link
Member

I suggest removing the game selection bar on Android, and flipping the "start game" form to have the list and 3 buttons on the left, and checks on the right

@rubenwardy
Copy link
Member

Unfortunately this would be harder than I expected, due to the fields added by host server

flipping the "start game" form to have the list and 3 buttons on the left, and checks on the right

I've done the first section though, in #7940. It also hides the header

@stujones11
Copy link
Contributor

I've done the first section though, in #7940. It also hides the header

In that case I don't see a problem with this 👍

@paramat
Copy link
Contributor Author

paramat commented Dec 5, 2018

The simple menus for Android add a lot of code though, better to remove that and have PC and Android being as similar as possible.

@paramat paramat removed Blocker The issue needs to be addressed before the next release. High priority labels Dec 5, 2018
@paramat paramat removed this from PR in Minetest 5.0.0 blockers Dec 5, 2018
@paramat paramat removed this from the 5.0.0 milestone Dec 5, 2018
@paramat paramat added Blocker The issue needs to be addressed before the next release. WIP The PR is still being worked on by its author and not ready yet. High priority labels Dec 5, 2018
@paramat paramat added this to the 5.0.0 milestone Dec 5, 2018
@paramat
Copy link
Contributor Author

paramat commented Dec 5, 2018

WIP as this might as well include the removal of simple menu code also, otherwise i'll just have to work on this code again soon.
Waiting for confirmation that full is fine for all Android devices, which will be likely if #7940 is merged.

@paramat paramat removed the WIP The PR is still being worked on by its author and not ready yet. label Dec 6, 2018
@paramat
Copy link
Contributor Author

paramat commented Dec 6, 2018

Actually not WIP. I can remove simple menu code in a separate PR (probably best).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Blocker The issue needs to be addressed before the next release. High priority One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants