Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable game bar and header on Android #7940

Merged
merged 1 commit into from Dec 6, 2018
Merged

Disable game bar and header on Android #7940

merged 1 commit into from Dec 6, 2018

Conversation

rubenwardy
Copy link
Member

@rubenwardy rubenwardy commented Dec 4, 2018 •
edited

From #7936

image

@rubenwardy rubenwardy changed the title Disable game bar on Android Disable game bar and header on Android Dec 4, 2018
@rubenwardy rubenwardy mentioned this pull request Dec 4, 2018
Merged
@stujones11
Copy link
Contributor

👍 I don't much see the point of this on any device, tbh.

@paramat
Copy link
Contributor

paramat commented Dec 5, 2018 •
edited

stujones11, because worlds are only shown for the game currently selected, which i think is obviously correct. The game icons are also nice to look at and would never be seen otherwise.
I'd prefer to keep the gamebar for Android if possible for those reasons, but won't oppose this PR.

@paramat paramat added Blocker The issue needs to be addressed before the next release. High priority labels Dec 5, 2018
@paramat paramat added this to the 5.0.0 milestone Dec 5, 2018
@stujones11
Copy link
Contributor

The game icons are also nice to look at and would never be seen otherwise.

This is a fair point, I guess it makes more sense to those with multiple games installed. However, keeping this for android does complicate the scaling and I would rather not see the overall menu size reduced for the sake of this feature.

@paramat
Copy link
Contributor

paramat commented Dec 6, 2018

Yes this PR does seem possibly the best and simplest solution.

@paramat paramat merged commit 0c6933b into minetest:master Dec 6, 2018
@paramat paramat removed this from PR in Minetest 5.0.0 blockers Dec 6, 2018
@paramat paramat mentioned this pull request Dec 6, 2018
Closed
Wuzzy2 pushed a commit to Wuzzy2/minetest that referenced this pull request Dec 11, 2018
@rubenwardy @Wuzzy2
Disable game bar and header on Android (minetest#7940)
b7a7e4e
osjc pushed a commit to osjc/minetest that referenced this pull request Jan 23, 2019
@rubenwardy @osjc
Disable game bar and header on Android (minetest#7940)
9fa457e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerzhul nerzhul nerzhul approved these changes

Assignees
No one assigned
Labels
Android Blocker The issue needs to be addressed before the next release. High priority One approval ✅ ◻️
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rubenwardy @stujones11 @paramat @nerzhul