Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix texture leak due to extruded textures not beeing cleaned up #803

Closed
wants to merge 1 commit into from
Closed

Fix texture leak due to extruded textures not beeing cleaned up #803

wants to merge 1 commit into from

Conversation

sapier
Copy link
Contributor

@sapier sapier commented Jul 2, 2013

No description provided.

@kahrl
Copy link
Contributor

kahrl commented Jul 2, 2013

from #minetest-dev
<kahrl> sapier: that patch is wrong
<kahrl> it shouldn't be added to the list if cc->inventory_texture came from tsrc
<kahrl> really that whole m_extruded_textures hack should be removed and generateTextureFromMesh moved to ITextureSource
<kahrl> so that ITextureSource is responsible for deleting the textures

kahrl added a commit that referenced this pull request Jul 3, 2013
@kahrl
Move generateTextureFromMesh to TextureSource to fix a texture leak
8f1d5d3 
TextureSource has a list of textures to delete (m_texture_trash) so this
provides a proper, non-hacky way to delete RTT textures. Also, the prior,
hacky way of deleting them seems to be broken (see pull request #803).

To avoid header file clutter by repeating the same long list of
arguments over and over again, store the arguments of
generateTextureFromMesh in a struct called TextureFromMeshParams.

Also fix issue #782 (Only use bilinear (and others) on item textures
when settings allow it).
@kahrl
Copy link
Contributor

kahrl commented Jul 3, 2013

8f1d5d3

@kahrl kahrl closed this Jul 3, 2013
proller pushed a commit to proller/minetest that referenced this pull request Jul 4, 2013
@kahrl @proller
Move generateTextureFromMesh to TextureSource to fix a texture leak
ec73ce3 
TextureSource has a list of textures to delete (m_texture_trash) so this
provides a proper, non-hacky way to delete RTT textures. Also, the prior,
hacky way of deleting them seems to be broken (see pull request minetest#803).

To avoid header file clutter by repeating the same long list of
arguments over and over again, store the arguments of
generateTextureFromMesh in a struct called TextureFromMeshParams.

Also fix issue minetest#782 (Only use bilinear (and others) on item textures
when settings allow it).
@sapier sapier deleted the fix_extruded_textures_leak branch February 8, 2014 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sapier @kahrl