getS16NoEx() returns true unless syntactical error in conf. #8304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The getS16NoEx() handler will return true unless there is a
[num_emerge_threads]
line in theminetest.conf
at whichpoint the excption handler part is reached. Due to the fact that
defaultsettings.cpp
has a default value set for this setting,that never will happen.
Because of this, the code will never check the number of threads on
the system, and keep
nthreads = 0
. If that happens, the value ischanged to
1
and only 1 emerge thread will be used.The default should be set to
1
instead, due to the potential unsafeconsequences for the standard sqlite map files, but that should be a
separate commit that also adds documentation for that setting. This
commit focuses on removing this
hiding
bug instead.