Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attached particle spawners no longer rotate with object #8362

Closed
orwell96 opened this issue Mar 11, 2019 · 1 comment
Closed

Attached particle spawners no longer rotate with object #8362

orwell96 opened this issue Mar 11, 2019 · 1 comment
Labels
Duplicate

Comments

@orwell96
Copy link
Contributor

orwell96 commented Mar 11, 2019 •
edited

Issue type
  • Bug report
Minetest version
5.0.0 (stable)
Summary

Until 0.4.17.1, the particle position of attached particle spawners used to rotate with the object they were attached to. #4781. I use this behavior in advtrains to make the steam engines produce steam.
However, probably since either the rotation PR or the latest particlespawner fixes, this is broken and positons are world-absolute again. (I can't test right now what exactly reverted it, I'm on mobile)
Original report here:
https://forum.minetest.net/viewtopic.php?f=11&t=14726&p=345821#p345745

Steps to reproduce

Install advtrains, place a steam engine and check the smoke.
@paramat
Copy link
Contributor

paramat commented Mar 11, 2019 •
edited

Duplicate of #8363 and #4781 is wrong PR.

@paramat paramat closed this as completed Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paramat @orwell96