Rename logfile to minetest.log by default

[ClobberXD]

Changes

• Make logfile name configurable. Relevant minetest.conf setting: logfile_name.
• logfile_name defaults to minetest.log.
• Replace all hard-coded occurrences of debug.txt in the code with the actual logfile name
• Report selected logfile name (incl. full path) to terminal on startup.

A couple of reasons for the proposed changes

• Customizable logfile name is a fundamental feature, IMHO.
• The default logfile name of debug.txt makes Minetest sound more like a beta game, which it isn't. :)
• The proposed default logfile name makes Minetest sound more polished. (This is basically an extension of the previous point)
• There are so many other things that are logged in that file other than just warnings and errors.
• The .log file extension is the de-facto standard for log files.

[paramat]

The .log file extension is the de-facto standard for log files.

It doesn't matter what the standard is, let's just do what's best for MT.
'minetest.log' sounds ok to me, consistent with 'minetest.conf'.

[benrob0329]

Things tend to be standard for a reason. If most software behaves in a certain way, its usually because its sane behavior that users expect.

[paramat]

I mostly agree and i didn't state otherwise. It's useful to consider the standard as it may be a good idea, but it's not necessarily right for MT.

[rubenwardy]

I don't think that the benefits of this are worth changing all the documentation and any bash scripts that rely on this

[ClobberXD]

I don't think that the benefits of this are worth changing all the documentation and any bash scripts that rely on this

That's not a very strong reason to support sticking to this name. I'll add a setting to make logfile name configurable - this is something I'd consider essential, even without changing the default name.

[ClobberXD]

Added a new setting for customizing logfile name - logfile_name (duh :P). See the updated first post for current status of this PR.

[rubenwardy]

We really don't need more configuration options. This would make more sense as a command line argument
EDIT: which already exists, as --logfile

[ClobberXD]

Also, look how many times debug.txt appears in random deployment things

Should I retain the default name then?

This would make more sense as a command line argument

We already have a --logfile switch.

Keeping these points in mind, what should be done now?

[paramat]

I agree with rubenwardy and SmallJoker (emoticon support).
And a setting is certainly overkill.
👎