minimal: Fix crash due to assertion fail #8511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The assertion failed because the third set_hp call in run_hpchangereason_tests set the same HP value, and on_hpchange callbacks weren't called.
rubenwardy
added
the
Trivial
paramat
reviewed
May 2, 2019
|
Fix is fine, unsure about the codestyle change. I'm not sure if it is our policy to change arguments to '_', code seems clearer with all arguments included. |
|
I seem to remember in MTG we are actually adding arguments back in and removing '_', because it helps by making clear what arguments are available. |
SmallJoker
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8510 (thanks to @DS-Minetest for reporting the crash). Tested; works as it should.