Use CDB author and name in installed package's config #8550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are used for tracking the package, so should match ContentDB.
|
Authors should be compared case insensitively, maybe I'm forgetting a :lower() |
|
OK, did that. |
p-ouellette
force-pushed
the
cdb_author_conf
branch
from
8d425cd
to
81f7893
Compare
rubenwardy
reviewed
May 23, 2019
| end | ||
| end | ||
|
|
||
| local game_hash = {} | ||
| pkgmgr.update_gamelist() | ||
| for _, game in pairs(pkgmgr.games) do | ||
| if game.author then | ||
| game_hash[game.author .. "/" .. game.id] = game | ||
| if game.author ~= "" then |
There was a problem hiding this comment.
I don't think this should work. author should either be filled or nil, but never an empty string
There was a problem hiding this comment.
Actually the tables returned by get_games always have the author field
https://github.com/minetest/minetest/blob/master/src/script/lua_api/l_mainmenu.cpp#L434
rubenwardy
approved these changes
Jun 10, 2019
rubenwardy
added
@ Content / PkgMgr
One approval ✅ ◻️
Bugfix 🐛
SmallJoker
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8269 (specifically the issue with MTG not being detected because of a different author in the game.conf. Preinstalled games without an author in the game.conf won't be detected, but that probably can't be fixed since there's no guarantee that it's the same game as the one on CDB.)