Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do predict when sneak-place to node with on_rightclick #8639

Merged
merged 1 commit into from Jul 8, 2019
Merged

Do predict when sneak-place to node with on_rightclick #8639

merged 1 commit into from Jul 8, 2019

Conversation

Desour
Copy link
Member

@Desour Desour commented Jun 29, 2019

Fixes #4270.

To do

This PR is a Ready for Review.

How to test

  • Place a node that has an on_rightclick field in its node definition. (Eg. wooden door or chest from mtg.)
  • Place a node to it holding sneak.
  • Hear the place sound.

@SmallJoker SmallJoker added @ Script API Bugfix 🐛 PRs that fix a bug labels Jun 29, 2019
@Desour Desour mentioned this pull request Jul 8, 2019
Closed
@sfan5 sfan5 merged commit 140aeab into minetest:master Jul 8, 2019
@Desour Desour deleted the place_predict_fix branch July 8, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfan5 sfan5 sfan5 approved these changes

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug @ Script API >= Two approvals ✅ ✅
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shift+click to build on node with right click action does not cause build sound to play
3 participants
@Desour @sfan5 @SmallJoker