New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add chat_log_level setting #9223
Conversation
{ | ||
bool colored_message = (Logger::color_mode == LOG_COLOR_ALWAYS) || | ||
(Logger::color_mode == LOG_COLOR_AUTO && is_tty); | ||
if (colored_message) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No functional changes. Added braces here according to the code style guidelines.
Pinging @Wuzzy2 because he requested this feature. |
Thanks, I have tested this for a bit now. So, one problem I found is that Minetest does not guarantee the log message actually appears in chat if that log message appears early at startup time. I can reliably reproduce this with the following steps:
The warning should be visible in chat. But it won't be visible. When I restart Minimal Development Test (WITHOUT restarting Minetest!), the warning will then reliably appear on every subsequent restart. Now some random nitpicks:
I don't like descriptions that are written in the form “it works like setting XYZ”. Better write a full standalone description instead, even if it's a little redundant. Why? Because in Minetest, the user will only see one setting description at a time, and it's just inconvenient when you have to hunt down the other setting just to find out what There's a leading space before the tab in line 400 of |
Log all higher levels in LogOutputBuffer Move StreamLogOutput::logRaw to source file like LogOutputBuffer::logRaw for compiling speed
c495663
to
d8119d5
Compare
d8119d5
to
fc7d404
Compare
Works fine for me now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works.
Closes #9199.
chat_log_level
to log to the chatlog.h
cleanup -> move to source file for compiling timeTo do
This PR is Ready for Review.
How to test