Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes around ServerActiveObject on_punch handling #9459

Merged
merged 1 commit into from Mar 5, 2020
Merged

Fixes around ServerActiveObject on_punch handling #9459

merged 1 commit into from Mar 5, 2020

Conversation

sfan5
Copy link
Member

@sfan5 sfan5 commented Mar 4, 2020 •
edited

  • Fixes 2. from this comment Punchwear (improved) #8959 (comment)
  • Fixes inaccurate hpchange reason (currently irrelevant, since unused)
  • Document return value of LuaEntity on_punch
  • Fix ObjectRef being unusable at the time on_death is called

To do

This PR is a Ready for Review.

@sfan5 sfan5 added @ Script API Bugfix 🐛 PRs that fix a bug labels Mar 4, 2020
@sfan5 sfan5 force-pushed the sao_punch branch 2 times, most recently from 4bd1df9 to 6eb2ad4 Compare March 4, 2020 18:39
@MoNTE48
Copy link
Contributor

MoNTE48 commented Mar 4, 2020 •
edited

...continue the discussion...
@sfan5 although this made the mobs_redo code work again, why does the builtin wear handling still not work?
Pls, add Blocker / High priority labels.

@sfan5
Copy link
Member Author

sfan5 commented Mar 4, 2020

Works for me:
gif

@MoNTE48
Copy link
Contributor

MoNTE48 commented Mar 4, 2020

@sfan5 You're right. But only after I set punch_attack_uses.
Also does not work with mobs_redo when i remove hitter:set_wielded_item(weapon).
But that is a different issue.

SmallJoker
SmallJoker approved these changes Mar 5, 2020
View reviewed changes
Copy link
Member

@SmallJoker SmallJoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfan5 sfan5 merged commit e774d8c into minetest:master Mar 5, 2020
@sfan5 sfan5 deleted the sao_punch branch March 5, 2020 21:04
@Wuzzy2 Wuzzy2 mentioned this pull request May 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SmallJoker SmallJoker SmallJoker approved these changes

Assignees
No one assigned
Labels
Bugfix 🐛 PRs that fix a bug One approval ✅ ◻️ @ Script API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sfan5 @MoNTE48 @SmallJoker