Fix Media... 0% on loading screen #9478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nerzhul
requested changes
Mar 8, 2020
|
Maybe, while you're at it: would it be much effort to include the percentage into the translation string, like it's done for "Initializing Nodes 45% ..."? (compare "Media ... 45%"). Maybe we could fix this inconsistency now. |
|
@orwell96 where is this |
MoNTE48
changed the title
|
@nerzhul you can check it again? Just few lines. |
|
Ping! |
rubenwardy
approved these changes
Oct 21, 2020
rubenwardy
added
One approval ✅ ◻️
Trivial
HybridDog
pushed a commit
to HybridDog/minetest
that referenced
this pull request
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who was not annoyed that when loading a game with large textures and models while checking cached resources, the client can show Media...0% for a long time?
Especially during a singleplayer game on a weak PC.
(Only "Media" show % when loading, by the way.)
Now it will look as it should:
Item definitions...
Node definitions...
Media...
Media... *%