Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowers: Make flower spread a public function to enable override #1044

Closed
wants to merge 1 commit into from
Closed

Flowers: Make flower spread a public function to enable override #1044

wants to merge 1 commit into from

Conversation

paramat
Copy link
Contributor

@paramat paramat commented Apr 16, 2016

Remove search for 'group:flora_block'
Enable flora spread on 'dirt with dry grass'
/////////////////////////////

Simplifies the function for most users and enables function override for mods, such as plantlife, which use the 'flora_block' group.

@paramat paramat added this to the 0.4.14 milestone Apr 16, 2016
@paramat
Copy link
Contributor Author

paramat commented Apr 18, 2016

Tested.
But discovered issues: dry grasses are flora but do not spread, i will change the code to allow spread on dirt with dry grass. This may allow green grass and flowers to spread onto savanna, and allow dry grasses to spread onto green grass, will test to see if this is a problem. Spread tends to self-limit it's distance so hopefully we can avoid non-native decorations spreading to far.

Or now grasses have groups we can use groups to control spread on certain surfaces.

Remove search for 'group:flora_block'
Enable flora spread on 'dirt with dry grass'
@paramat
Copy link
Contributor Author

paramat commented Apr 18, 2016

Updated. Dry grass can now spread in savanna.
Coded the simple way which allows some spread into neighbour biomes, possibly an interesting side effect.

@paramat
Copy link
Contributor Author

paramat commented Apr 18, 2016

screenshot_20160418_023647

In testing this was the most cross-biome spread i observed, the first flower is just above the crosshair, this screenshot is when the spread had setled down and stabilised. Possibly a nice effect?
Here decorations were disabled, in actual mapgen the surrounding grasses would limit spread to less than this.
This commit does mean that flora can spread on non-native surfaces.

@paramat
Copy link
Contributor Author

paramat commented Apr 19, 2016

I'll merge this on one approval due to it being semi-trivial, freeze being close and other devs being absent.

@paramat
Copy link
Contributor Author

paramat commented Apr 19, 2016

ab7b7c7

@paramat paramat closed this Apr 19, 2016
@paramat paramat deleted the flowerfunction branch April 19, 2016 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant