[register_lbm farming api] Name farming:start_nodetimer_ does not follow naming conversation

[adrido]

Hi,
I have troubles to get a mod working with minetest 0.4.14 which worked fine in 0.4.13
I found out that the problem seems to be in the new farming API line 352.
if you register a new plant with farming.register_plant("mymod:myplant",{...}) you will get an error because lbm does not following "naming conventions"

reproducable: yes

Code from logfile:

2016-05-28 18:30:32: ERROR[Main]: ModError: Failed to load and run script from /home/minetest/minetest/bin/../games/minetest/mods/beer_test/init.lua:
2016-05-28 18:30:32: ERROR[Main]: /home/minetest/minetest/bin/../builtin/game/register.lua:62: Name farming:start_nodetimer_beer_test_oats does not follow naming conventions: "beer_test:" or ":" prefix required
2016-05-28 18:30:32: ERROR[Main]: stack traceback:
2016-05-28 18:30:32: ERROR[Main]:   [C]: in function 'error'
2016-05-28 18:30:32: ERROR[Main]:   /home/minetest/minetest/bin/../builtin/game/register.lua:62: in function 'check_modname_prefix'
2016-05-28 18:30:32: ERROR[Main]:   /home/minetest/minetest/bin/../builtin/game/register.lua:85: in function 'register_lbm'
2016-05-28 18:30:32: ERROR[Main]:   ...test/bin/../games/minetest/mods/mtg_core/farming/api.lua:352: in function 'register_plant'
2016-05-28 18:30:32: ERROR[Main]:   ...in/../games/minetest/mods/beer_test/mod_files/plants.lua:242: in main chunk
2016-05-28 18:30:32: ERROR[Main]:   [C]: in function 'dofile'
2016-05-28 18:30:32: ERROR[Main]:   ...t/minetest/bin/../games/minetest/mods/beer_test/init.lua:21: in main chunk

I assume line 353 schould look like this:

        name = mname..":start_nodetimer_" .. mname .. "_" .. pname,

instead of

        name = "farming:start_nodetimer_" .. mname .. "_" .. pname,

[sofar]

try

name = ":" .. mname..":start_nodetimer_" .. mname .. "_" .. pname,

instead, and let us know if that works.

[adrido]

yes, this works too

[sofar]

This is only a bug in current git, not 0.4.14.

[sofar]

@adrido would be nice if you can retest and comment in #1115 whether that fixes it for you as well (patch is slightly different).