Doors: Fix missing node parameter passing. #1189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes the issue for me. |
|
👍 |
| end, | ||
| state = function(self) | ||
| return node_name:sub(-5) == "_open" | ||
| return minetest.get_node(self.pos).name:sub(-5) == "_open" |
There was a problem hiding this comment.
This is the only bit i don't understand
@sofar is this ok?
There was a problem hiding this comment.
I've essentially reverted my previous removal here to force a new node lookup on self.pos.
This way, there is less chance for mods requesting an old state (e.g. after you closed or opened the door).
Removing this before was bad judgment on my part.
|
Anyway this is an urgent fix so will merge later. |
|
👍, untested but it should fix the bug from what I see. |
|
This fix works for me. |
Ping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1188.