Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unregister_item() to remove tnt:tnt if tnt is disabled. #1331

Closed
wants to merge 1 commit into from

Conversation

red-001
Copy link
Contributor

@red-001 red-001 commented Oct 15, 2016

This allows for disabling the default TNT and using other mods that register TNT using tnt.register_tnt()

@Ferk
Copy link
Contributor

Ferk commented Oct 15, 2016

Why not just prevent "tnt:tnt" from registering in the first place? Seems silly to register and then unregister.

You can still leave the register_tnt definition untouched for other tnt mods to use, instead just make the tnt.register_tnt call that uses it conditional.

But those other mods might as well just unregister (or override/replace) tnt:tnt themselves if that's what they want to do, don't you think?

Probably the intention of enable_tnt is precisely being able to disable all mods from registering tnt nodes by means of register_tnt (though I'm not sure why is the "_burning" variant of the tnt node left out).

@tenplus1
Copy link
Contributor

Current dev additions have 'disable_tnt = false' not register tnt:tnt and allow the use of tnt functions and tnt:tnt_burning for mods... No need to unregister a node.

@red-001 red-001 closed this Oct 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants