Metal sounds

[sofar]

2 commits:

• add default metal node sounds, including
  • digging sound
  • dug sound
  • footstep sound
  • place node sound
• make all metal nodes use the default metal sounds

[sofar]

I intend to use this in the #1318 PR, hence a separate PR

• fairly trivial
• will consider alternative sounds (I'm not entirely happy with all of them yet)
• applied to steel door, trapdoor, steel/copper/bronze blocks and steel ladder and sign

[sofar]

• sound volume (gain) most likely will need adjustment (it's probably too loud?)

[paramat]

I'll try them in-game. Maybe wait for feedback before doing all the volume balancing work.

[paramat]

I think the 'dig' sound should be called 'default_dig_metal' as 'break' suggests 'dug'. For example 'break glass' is the final shattering sound.

[paramat]

Your 'break metal' sound has an unnecessary '.1' in the name.

[sofar]

Yes, I really wanted to find another alternative sound sample (have 2-3 as much as possible).

The .1 in the name is entirely fine, it's not like it hurts...

[paramat]

Testing in-game. The footsteps, which i were at first unsure of, are ok at low volume.
The only one i dislike is the dug metal sound, it has a piercing ring to it which i find hard on the ears. I imagine it would be a little harsh with repetition.

[paramat]

Addresses #887

[Fixer-007]

Those are somewhat strange to me:
default_break_metal.1.ogg
default_metal_footstep.1.ogg
default_metal_footstep.2.ogg
default_place_node_metal.1.ogg
default_place_node_metal.2.ogg

[sofar]

Yes, these are very crude sound samples. They're mostly just placeholders until someone proposes or finds better sound samples. I wanted to make sure that (1) we'd get a full sound scape implemented for metal nodes (so cover footstep, dig/dug and place) and (2) make sure to use it in all the nodes.

If you have good and usable metal sounds you'd like to propose, please link in this thread.

[Fixer-007]

Hmmmmmmm, maybe freesounds has something useful

[JurajVajda]

So we are going to have iron, steel and metal now..? :) or is the metal sounds also for nodes like gold, copper, bronze...?

[Fixer-007]

Some crude ones...
https://www.freesound.org/people/Ottomaani138/sounds/232692/
https://www.freesound.org/people/Benboncan/sounds/103628/
https://www.freesound.org/people/jorickhoofd/sounds/160045/
https://www.freesound.org/people/jorickhoofd/sounds/160046/
https://www.freesound.org/people/xMETALCORERx/sounds/347779/
https://www.freesound.org/people/MorneDelport/sounds/326398/
https://www.freesound.org/people/yadronoff/sounds/320397/
https://www.freesound.org/people/taylorevanmcalister/sounds/223530/

more search here:
https://www.freesound.org/search/?q=steel&f=&s=score+desc&advanced=0&g=1
https://www.freesound.org/search/?q=metal&f=&s=score+desc&advanced=0&g=1

[paramat]

Sounds tend to be difficult to agree on, so i'm trying to not be too fussy. Many of our sounds are humorously crude so let's not be too perfectionist. I might look for an alternative dug sound.

[sofar]

@JurajVajda iron is a metal, steel is a metal, gold is a metal, bronze is a metal....

[paramat]

Here's a possible metal break sound https://www.freesound.org/people/JoelAudio/sounds/135465/

[sofar]

Entirely redone - updated licenses and origin, used many of the suggestions above.

This is fairly decent now! please try these in-game and check volume levels. I think it's all OK now.

[paramat]

Both dug sounds are too loud. Others seem okay in volume.

[sofar]

Lowered dug sounds to gain = 0.5 down from 1.0.

[paramat]

👍

[Fixer-007]

• no metal sounds when walking on metal slab/stair (or when placing them)
• compared dig volume of obsidian vs steel block with pickaxe: obsidian dig has more volume, metal dig sound has little less volume it seems, or maybe it is just obsidian dig bass effect.

Overall sounds seem good to me in game.

[sofar]

I'll see why slab/stair for metal nodes isn't getting these sounds, I thought it would be inherited.

[sofar]

Fixed metal sounds for stair/slabs for (copper/steel/bronze/gold) block derived versions.

[paramat]

👍

[Fixer-007]

Seems good now 👍

[paramat]

fa9a345
fbac9be