Add 'creative' privilege for survival servers #1543

tenplus1 · 2017-02-01T19:07:40Z

This adds a 'creative' privilege to survival servers which Ops can bestow on admin or competent builders to give access to creative features like the item inventory or continuous node placement.

Fixer-007 · 2017-02-02T16:48:23Z

Very useful for admins/moderators to work on ingame infrastructure without using cumbersome /giveme whatever...

sfan5 · 2017-02-02T21:34:34Z

mods/creative/init.lua

@@ -54,7 +57,7 @@ function minetest.handle_node_drops(pos, drops, digger)
 	end
 	local inv = digger:get_inventory()
 	if inv then
-		for _, item in ipairs(drops) do
+		for _, item in pairs(drops) do


pairs is slightly faster than ipairs when dealing with tables not containing numbers.

This is not exactly performance-critical code...

Whether pairs or ipairs is faster also depends on implementation:

local t = {1,1,2,3,5,8,13,21,34,55} local function timeit(f) local n = 0 local start = os.clock() for i = 1, 1000 do for _, x in f(t) do n = n + x end end return os.clock()-start end print("ipairs:", timeit(ipairs)) print("pairs:", timeit(pairs))

# luajit pairs.lua ipairs: 0.000156 pairs: 0.000598 # lua5.1 pairs.lua ipairs: 0.001272 pairs: 0.001225

It seems that ipairs and luajit work well together :)

This can change behaviour of the code; it is also not performance-critical.

numberZero · 2017-02-02T22:50:17Z

👍
unified_inventory gives admins (those who can giveme) access to the creative inventory already, but not other features like infinite stacks or instant recharge IIRC.

kaeza · 2017-02-03T09:01:40Z

mods/creative/init.lua

@@ -1,14 +1,17 @@
 creative = {}

+minetest.register_privilege("creative", {"Allow player to use creative inventory",


description =?

Does this even work?

Yes, it's running on Xanadu for now where admin have 'creative' privelages and access to the creative inventory/placement features.

sofar · 2017-02-04T09:45:25Z

This doesn't look so bad. But the new priv should be added to creative to assure those with the priv get the creative inventory tabs as well.

tenplus1 · 2017-02-04T18:14:31Z

Once the callbacks have been added for giving/revoking privs then we can tinker with the creative inventory side of things, but until then it'll set inventory on join.

zaoqi · 2017-02-09T14:40:55Z

#1554

SmallJoker · 2017-02-09T14:58:29Z

mods/creative/init.lua

@@ -1,14 +1,18 @@
 creative = {}

+minetest.register_privilege("creative", {
+		description = "Allow player to use creative inventory",
+                give_to_singleplayer = false})


Please use tabs here, as above in description.

tenplus1 · 2017-05-26T07:37:34Z

Weird, says branch has conflicts even when it hasn't... what's up with travis ?!?!

SmallJoker · 2017-05-26T13:40:18Z

@tenplus1 Your branch does not contain commit eec1c5a, thus it can't apply yor changes 1:1 on top of that.

This adds a 'creative' privilege to survival servers which Ops can bestow on admin or competent builders to give access to the creative inventory.

tenplus1 · 2017-05-26T20:06:00Z

@SmallJoker - thanks dude :)

Zeno- · 2017-06-07T09:29:20Z

👍

tenplus1 · 2017-06-08T10:31:28Z

@sfan5 - this is a very handy feature for survival servers and works really well, giving a use to minetest.is_creative(name)'s 'name' field.

paramat · 2017-06-08T10:40:34Z

👍

rubenwardy

👎 a privilege should be the right to do something, not a state you're in.

Being able to use the creative inventory based on a privilege is okay, but it's not okay to have node digging modified. Note that an admin has all privileges, as they have the right to do anything.

I think that get/set_attributes would be a better candidate for changing a player's creative/survival mode.

tenplus1 · 2017-06-09T10:17:30Z

@rubenwardy - I disagree, the creative priv will be granted to those trustworthy players on a survival server to allow them to build a lot easier with creative inventory and unlimited block placement. It is earned and definitely a privilege.

paramat · 2017-06-10T18:28:24Z

@Ekdohibs @ShadowNinja

ShadowNinja · 2017-06-10T19:22:05Z

👍

paramat · 2017-06-14T19:49:38Z

0157175

paramat · 2017-11-08T12:56:17Z

@Ezhh i read on IRC some dissatisfaction with MTG creative priv recently, please could you explain what you think is wrong with the MTG implementation?

rubenwardy · 2017-11-08T13:04:34Z

it changes the behaviour of the game, rather than giving you the right to do something.

Either:

the priv only gives you access to the creative inventory, doesn't effect dig times/amount picked up
or the priv allows you to change between creative and survival at will (my preference)

paramat · 2017-11-08T14:35:57Z

Oh just saw Ezhh was referring to MTG 'current stable', i read 'current' as meaning latest dev.
Dev version has the creative privilege, nevermind.

paramat · 2017-11-08T17:39:23Z

or the priv allows you to change between creative and survival at will (my preference)

Good idea, if someone has the creative priv they may sometimes find it irritating to be in creative mode due to how it affects inventory and crafting.

Ezhh · 2017-11-08T18:30:50Z

I'm travelling, so not able to test what creative is like in current dev at the moment, but my preference would be for it to do nothing other than let you take items from creative inventory. You should otherwise be able to collect items or craft as you wish. (This way even if you have creative priv on a survival server, you can still choose to play as normal if you wish to.)

I can't comment more than that until I know what current dev actually does.

paramat · 2017-11-09T08:51:20Z

I think anyone you grant creative to should also have long interact distance and fast node dig too, otherwise having creative won't be very useful for them when they need to alter the world.

I think anyone who is in 'creative mode' should have the full digging / placing / inventory abilities, and the priv should allow changing their gamemode to survival, as rubenwardy suggests. Then they will have both modes available instead of something halfway inbetween which does neither.
@rubenwardy i'll support the creative priv allowing choice of gamemode, i see you have a mod for this already.

Current master has tenplus1's creative priv added which puts the player into creative mode #1543

Ezhh · 2017-11-09T16:46:31Z

@paramat creative as I want it working certainly would not be considered "won't be very useful" by players or server owners, even without longer range / faster placement. Adding those automatically will make me less likely to give the priv to people because when I give someone creative on a survival server, I'm doing it so they have the variety of nodes to make a special building of some kind. (This is why it being a priv makes sense - it is giving the ability to use creative inventory). I'm not doing it to enable anything else and faster digging and so on is completely outside the scope of what I want.

The problem my comments were based on is when creative is either not an option at all on survival, or when it interferes with your ability to pick up nodes. I've seen versions of creative where you are reduced to stacks of 1 no matter how many of a node you pick up,and that's terrible for all kinds of reasons. But as I said before, I'm travelling until the weekend so I can't test what MTG is doing to see if it's this.

With all that said - it would be really nice if hand range was independently settable. This is something I have been wanting for a long time. Node removal range can already be adjusted by tools, but the hand is the hand, so placing is pretty limited. Even a separate setting for digging speed wouldn't be a bad thing, but please don't stack them all into survival mode creative without a lot more thought than this.

paramat · 2017-11-09T19:32:39Z

Ezhh has asked we don't touch creative until next week when she can test it. So everyone be lazy for a few days.

tenplus1 changed the title ~~Add 'creative' privelage for survival servers~~ Add 'creative' privilege for survival servers Feb 1, 2017

sfan5 reviewed Feb 2, 2017

View reviewed changes

kaeza reviewed Feb 3, 2017

View reviewed changes

tenplus1 mentioned this pull request Feb 9, 2017

Creative: Add privilege "creative" #1554

Closed

SmallJoker reviewed Feb 9, 2017

View reviewed changes

paramat added the Feature label Mar 1, 2017

Add 'creative' privilege for survival servers

ba5d249

This adds a 'creative' privilege to survival servers which Ops can bestow on admin or competent builders to give access to the creative inventory.

Zeno- added the One approval label Jun 7, 2017

red-001 approved these changes Jun 7, 2017

View reviewed changes

sfan5 removed the One approval label Jun 7, 2017

paramat added the One approval label Jun 8, 2017

sfan5 approved these changes Jun 8, 2017

View reviewed changes

sfan5 added >= Two approvals and removed One approval labels Jun 8, 2017

rubenwardy requested changes Jun 8, 2017

View reviewed changes

paramat closed this Jun 14, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'creative' privilege for survival servers #1543

Add 'creative' privilege for survival servers #1543

tenplus1 commented Feb 1, 2017 •

edited

Fixer-007 commented Feb 2, 2017

sfan5 Feb 2, 2017

tenplus1 Feb 3, 2017

kaeza Feb 3, 2017

tenplus1 Feb 3, 2017

Ekdohibs Feb 3, 2017

numberZero commented Feb 2, 2017

kaeza Feb 3, 2017

tenplus1 Feb 3, 2017

sofar commented Feb 4, 2017

tenplus1 commented Feb 4, 2017

zaoqi commented Feb 9, 2017

SmallJoker Feb 9, 2017

tenplus1 commented May 26, 2017

SmallJoker commented May 26, 2017

tenplus1 commented May 26, 2017

Zeno- commented Jun 7, 2017

tenplus1 commented Jun 8, 2017

paramat commented Jun 8, 2017

rubenwardy left a comment •

edited

tenplus1 commented Jun 9, 2017

paramat commented Jun 10, 2017

ShadowNinja commented Jun 10, 2017

paramat commented Jun 14, 2017

paramat commented Nov 8, 2017 •

edited

rubenwardy commented Nov 8, 2017

paramat commented Nov 8, 2017 •

edited

paramat commented Nov 8, 2017

Ezhh commented Nov 8, 2017

paramat commented Nov 9, 2017 •

edited

Ezhh commented Nov 9, 2017

paramat commented Nov 9, 2017

		@@ -1,14 +1,17 @@
		creative = {}

		minetest.register_privilege("creative", {"Allow player to use creative inventory",

Add 'creative' privilege for survival servers #1543

Add 'creative' privilege for survival servers #1543

Conversation

tenplus1 commented Feb 1, 2017 • edited

Fixer-007 commented Feb 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

numberZero commented Feb 2, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sofar commented Feb 4, 2017

tenplus1 commented Feb 4, 2017

zaoqi commented Feb 9, 2017

Choose a reason for hiding this comment

tenplus1 commented May 26, 2017

SmallJoker commented May 26, 2017

tenplus1 commented May 26, 2017

Zeno- commented Jun 7, 2017

tenplus1 commented Jun 8, 2017

paramat commented Jun 8, 2017

rubenwardy left a comment • edited

Choose a reason for hiding this comment

tenplus1 commented Jun 9, 2017

paramat commented Jun 10, 2017

ShadowNinja commented Jun 10, 2017

paramat commented Jun 14, 2017

paramat commented Nov 8, 2017 • edited

rubenwardy commented Nov 8, 2017

paramat commented Nov 8, 2017 • edited

paramat commented Nov 8, 2017

Ezhh commented Nov 8, 2017

paramat commented Nov 9, 2017 • edited

Ezhh commented Nov 9, 2017

paramat commented Nov 9, 2017

tenplus1 commented Feb 1, 2017 •

edited

rubenwardy left a comment •

edited

paramat commented Nov 8, 2017 •

edited

paramat commented Nov 8, 2017 •

edited

paramat commented Nov 9, 2017 •

edited