Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tin block stairs sometimes are black in inventory/hotbar (also slabs and other materials) #1959

Closed
Wuzzy2 opened this issue Nov 28, 2017 · 11 comments

Comments

@Wuzzy2
Copy link
Contributor

Wuzzy2 commented Nov 28, 2017

Very weird, in ed83e30, some (normal) stairs, inner stairs and outer stairs turn sometimes completely black in the hotbar, or when you pick them up via left click in the inventory.
In the hotbar, the affected stairs are only black if you have not selected it. If you highlighted it, the stairs look normal again.
It looks like an ordinary stair inventory image, except that all color pixels are black.
The wieldhand is OK.

Oddly, this happens especially with tin block stairs. I haven't seen this for other stair types so far.

MT version: c0dd4ea
MTG version: ed83e30

@paramat paramat added the Bug label Nov 28, 2017
@paramat
Copy link
Contributor

paramat commented Nov 28, 2017

I did recently change these 3 to nodeboxes, maybe i made a mistake?

@TumeniNodes
Copy link
Contributor

Tin stairs were added after the fact paramat, remember? Maybe something small missed in the code when they got added?
It is odd, I have never noticed this

@paramat
Copy link
Contributor

paramat commented Nov 30, 2017

Tin block texture looks ok.
Can't reproduce yet.

@paramat paramat changed the title Tin block stairs sometimes are black in inventory/hotbar Tin block stairs sometimes are black in inventory/hotbar (also slabs and other materials) Dec 9, 2017
@paramat
Copy link
Contributor

paramat commented Dec 9, 2017

I just got dark slabs and stairs in aspen wood:

screenshot_20171209_011831

screenshot_20171209_011834

screenshot_20171209_011912

screenshot_20171209_012040

Creative mode, fetching a slab and a stair from creative inventory.
The bug only happens if the stair and slab have the same parent node (same material).

During a game session certain hotbar slots cause darkness, some are ok.
Moving both around, the darkness can switch from one to the other, but only one can be dark at any one time.
The dark node is the one in the higher slot, therefore nodes are never dark in the first hotbar slot.
If A is dark, moving B to a non-hotbar slot fixes A. returning B tothe hotbar makes A dark again.
Placing the slab and stair each side of the highlighted hotbar slot fixes both.
Nodes are never dark in the highlighted slot.
Adding a third slab/stair node creates more complex behaviour.

MT ea1ae07
MTG ed83e30

@paramat
Copy link
Contributor

paramat commented Dec 9, 2017

Possibly engine related.

@Fixer-007
Copy link
Contributor

Fixer-007 commented Dec 10, 2017

Confirmed on engine d677f29 with sandstone outer stair (black on hotbar when not selected, only certain block in certain hudbar position is affected in my situation, block in world and inventory itself are fine). Placing other nodeboxes like doors, torches in that spot does not produce the bug.
4a8p4tg
heh2
kek
Shaders off, OGL 2.1

This issue is not related to minetest/minetest#4876

@rubenwardy
Copy link
Member

This smells like an engine bug

@Thomas--S
Copy link
Contributor

I experienced a very similiar thing with items from other mods on my server, so I think rubenwardy is right: This seems to be an engine bug.

@Fixer-007
Copy link
Contributor

Fixer-007 commented Dec 11, 2017

More notes:

  • Persists after complete game restart (at least on the same world restart).
  • When shaders enabled - it is invisible in hotbar.
  • When shaders enabled and mipmapping disabled - it is black in hotbar.

Bisecting results

This regression was introduced in minetest/minetest@ee6bb5a (minetest/minetest#6596) "Fix item and wield meshes" by @numberZero

@paramat
Copy link
Contributor

paramat commented Dec 11, 2017

Thanks.

@paramat
Copy link
Contributor

paramat commented Jan 20, 2018

minetest/minetest#6780 merged.

@paramat paramat closed this as completed Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants