Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Balance sounds, remove silent water footstep #2774

Merged
merged 1 commit into from Jan 23, 2022
Merged

Balance sounds, remove silent water footstep #2774

merged 1 commit into from Jan 23, 2022

Conversation

paramat
Copy link
Contributor

@paramat paramat commented Nov 8, 2020

Closes #2749

I created a sound testing area for my PR #2768 so i decided to make more use of it and check and balance all other MTG sounds.
Some new sounds were added recently and some of these needed a little adjustment.
All MTG sounds were tested for balance, any not appearing in this PR were therefore already balanced.

Many positional sounds were too loud because testing was not done at a close distance.
To balance positional sounds i moved the player as close as possible to the sound, then adjusted for a 'fairly loud but suitably and not uncomfortably loud' volume.

Changes:

  • Many footsteps were too loud (as reported in a recent issue):
    Wood. Often complained about as a too-loud 'player is wearing clogs' sound.
    Dirt.
    Stone 'hard footstep'.
    Ice footstep.
    Metal footstep. The high volume made metal sound thin, hollow and 'tinny', not solid.
  • Gravel footstep was actually too quiet =) Gravel is loud to walk on.
  • 'default dig choppy' was slightly too loud. It was left undefined so fell back to its engine default gain of 0.5. Now it is defined in the wood sound defaults table as 0.4.
  • 'default dig crumbly' was slightly too loud. It was left undefined so fell back to its engine default gain of 0.5. Now it is defined in the dirt sound defaults table as 0.4.
  • Active furnace sound was too loud.
  • Furnace item smelt was too loud.
  • Torch 'on flood' was too loud.
  • 'cool lava' was too loud.
  • 'item smoke' had undefined gain, defaulting to 1.0, now it is specified as 1.0 for clarity.
  • Flint and steel was too loud.
  • 'gunpowder burning' was set at gain 2.0. Any value exceeding 1.0 results in a volume that to some extent does not reduce with distance. Now set to 1.0 and volume changes suitably with distance.
  • 'tnt ignite' had undefined gain, defaulting to 1.0, now it is specified as 1.0 for clarity.
  • Hoe on use was too loud, now balanced with 'default dig crumbly' (note: as this is a positional sound, the balance occurs at 0.3, not 0.4).
  • The silent water footstep sound (4) is removed as it often causes swimming sounds to be excessively delayed when first entering the water. Also, excessively long silences can occur when 2 silent sounds are played in sequence.

@KaylebJay
Copy link

Nice work, I'll have to test this.

@paramat
Copy link
Contributor Author

paramat commented Apr 2, 2021

Simple and easy to review PR with a large benefit to very many users. Many sound levels are poorly balanced, and further balancing was also needed for the new sounds recently added. Therefore seems a fairly important PR.

I will probably not work further on this PR so if a core dev wants something changed to make it approvable feel free to make the change and then merge it.

@paramat
Copy link
Contributor Author

paramat commented Dec 27, 2021

1 year bump =D
This PR really should be merged, it is high priority fundamental maintenance.

The new footstep sounds were merged without their sounds being properly balanced, the intention was too balance the sounds in a follow up PR, which is this PR.
This PR also fixes some broken stuff related to sounds code, and fixes the silent water problem.
Apart from the above, all other sounds have been checked and were balanced if necessary, some were in a very bad state.

I was a core dev when i submitted this PR so i think my approval should still count, meaning only 1 extra approval is needed.
If no-one has time to review, just merge it long before a release and check the levels are ok as you subsequently use MTG, you can always adjust later if necessary. This is very good work and i could be trusted at the time i submitted this.

Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested a few, sounds good.

@sfan5 sfan5 added this to the 5.5.0 milestone Jan 9, 2022
@appgurueu appgurueu self-requested a review January 18, 2022 07:51
Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Literally sounds well.

@appgurueu appgurueu merged commit 0c1252b into minetest:master Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sounds files need volume balance
4 participants