Hoe usage count is off

[Wuzzy2]

The hoe usage count is off.

• Steel Hoe: Expected: 500 uses. Actual: 501 uses
• (legacy) Mese Hoe: Expected: 350 uses. Actual: 351 uses
• (legacy) Diamond Hoe: Expected: 500 uses. Actual: 501 uses
• Wood/Stone Hoe: Are fine (due to coincidence)
• All custom hoes (those registered with the game API) with a high uses count are also affected

The error increases the higher the number of uses (up to tens of thausands).

Reason for this bug

This is basically minetest/minetest#4900, but in Minetest Game. The same mistake is done as was done in the engine: The naive calculation add_wear(65535/(uses-1)) that is currently used won't always get in the number of uses you want due to rounding errors. The larger the number of desired uses, the larger the rounding error is (see #11110 for an in-depth analysis).

Possible fix

Merge minetest/minetest#12047 into Minetest, then replace the naive wear calculation with item:add_wear_by_uses(number_of_uses_that_you_want_the_tool_to_have_before_it_breaks). ;-)

This is a helper function made specifically for this use case.

[Wuzzy2]

If minetest/minetest#12047 gets merged, this issue is fixable for MTG.

[Wuzzy2]

The required engine change was made.
PR: #2959