Don't check protection of air when placing bones

[OgelGames]

It doesn't make sense to check the protection of air nodes, and it makes bone placement fail more often.

[rollerozxa]

Won't this lead people to being able to effectively grief areas which are protected? Filling up a protected spawn with bones by repeatedly killing yourself, or the like.

[OgelGames]

Won't this lead people to being able to effectively grief areas which are protected? Filling up a protected spawn with bones by repeatedly killing yourself, or the like.

That is already possible, this just changes the secondary check to match the logic in may_replace() (which is only called for the initial position):

minetest_game/mods/bones/init.lua

Lines 144 to 152 in 986b657

	-- allow replacing air
	if node_name == "air" then
	return true
	end
	-- don't replace nodes inside protections
	if minetest.is_protected(pos, player:get_player_name()) then
	return false
	end

[appgurueu]

That is already possible, this just changes the secondary check to match the logic in may_replace() (which is only called for the initial position)

Why don't you switch the "find nearby pos" to may_replace() entirely? Ideally there should IMO be a hierarchy:

1. Try placing bones where the player died;
2. Try nearby positions, checking may_replace() - prefer air over buildable nodes, unprotected over protected etc.

That said, this change is reasonable and at least partially fixes the issue.

[OgelGames]

Why don't you switch the "find nearby pos" to may_replace() entirely?

Because that would be more complicated and I just wanted to fix this small mistake without changing too much. I do agree that checking every position with may_replace() would be more thorough.

[appgurueu]

Probably fixes 99% of cases frequently encountered on servers