Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bookshelves don't update their infotext properly #3037

Closed
Montandalar opened this issue Jun 6, 2023 · 0 comments · Fixed by #3038
Closed

Bookshelves don't update their infotext properly #3037

Montandalar opened this issue Jun 6, 2023 · 0 comments · Fixed by #3038
Labels

Comments

@Montandalar
Copy link
Contributor

The local function update_bookshelf creates the metadata formspec attached to a bookshelf and sets its infotext according to the number of books inside.

However, in the current implementation this function is only called in the node's on_construct, and never again afterwards. If you place books inside the bookshelf and take them out, the infotext will never change. The inventory handler callbacks are set to log actions to the server log, but they should also update the infotext.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants