New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace nonfree water textures #3056
Conversation
Replaces water textures to avoid licence problems.
Thanks! The textures are looking good. Could you please also edit |
Ofcourse! How do i go about that? Do i edit it and then make another PR?:) |
The colour is now closer to river water which makes them more difficult to distinguish. I'd prefer to have it a bit darker like in the current textures PS: Have you yet run |
Ran `optipng -strip all FILENAME` on files and reduced file size.
I have now run
It seams like they are further away from each other now than before, and it thus would be easier to distinguish them?:) Tho the river water is now way less transparent. |
Made the `default_river_water.png` and it's relatives more transparent.
You should be able to just edit it on the |
Done!:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Oh yeah! Ur compleatly right! I'll fix that rn:) |
Corrected a miss-alignment in hue between running and still non-river water.
I would want to drink this water. |
Haha^^ That seams like a good "is it good-enough" check for water textures:) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good going by screenshots
Merging this since free water is better than nonfree water. Further improvements to the textures can be proposed in later PRs. |
Replaces water textures to avoid licence problems.
Closes #3051.