Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace nonfree water textures #3056

Merged
merged 6 commits into from Sep 4, 2023
Merged

Conversation

Loppansson
Copy link
Contributor

@Loppansson Loppansson commented Aug 27, 2023

Replaces water textures to avoid licence problems.

Closes #3051.

Replaces water textures to avoid licence problems.
@appgurueu
Copy link
Contributor

Thanks! The textures are looking good. Could you please also edit license.txt to clarify that you are licensing these textures under a free license (and to attribute yourself ;))?

@Loppansson
Copy link
Contributor Author

Thanks! The textures are looking good. Could you please also edit license.txt to clarify that you are licensing these textures under a free license (and to attribute yourself ;))?

Ofcourse! How do i go about that? Do i edit it and then make another PR?:)

@SmallJoker
Copy link
Member

SmallJoker commented Aug 28, 2023

The colour is now closer to river water which makes them more difficult to distinguish. I'd prefer to have it a bit darker like in the current textures but also more transparent. Any other opinions?

comparison

PS: Have you yet run optipng -strip all FILENAME on your textures? They seem to be a bit bigger than expected.

Ran `optipng -strip all FILENAME` on files and reduced file size.
@Loppansson
Copy link
Contributor Author

Loppansson commented Aug 28, 2023

PS: Have you yet run optipng -strip all FILENAME on your textures?

I have now run optipng -strip all FILENAME; thank you for pointing that out!:)

The colour is now closer to river water which makes them more difficult to distinguish.

It seams like they are further away from each other now than before, and it thus would be easier to distinguish them?:)

Old:
image

New:
image

Tho the river water is now way less transparent.

Made the `default_river_water.png` and it's relatives more transparent.
@Loppansson
Copy link
Contributor Author

Loppansson commented Aug 28, 2023

Now the river water is more transparent (like the current texture:)
image

@appgurueu
Copy link
Contributor

Thanks! The textures are looking good. Could you please also edit license.txt to clarify that you are licensing these textures under a free license (and to attribute yourself ;))?

Ofcourse! How do i go about that? Do i edit it and then make another PR?:)

You should be able to just edit it on the master branch of your fork for it to show up in this PR. Here's a link to directly edit it on GitHub.

@Loppansson
Copy link
Contributor Author

Done!:)

Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@appgurueu
Copy link
Contributor

appgurueu commented Aug 28, 2023

One thing that sticks out to me: The water source seems to have a slightly different hue than the flowing water?

Screenshot

Waiting for input on how others receive the textures.

@Loppansson
Copy link
Contributor Author

Oh yeah! Ur compleatly right! I'll fix that rn:)

Corrected a miss-alignment in hue between running and still non-river water.
@Loppansson
Copy link
Contributor Author

Loppansson commented Aug 28, 2023

Corrected hue:
image

@rollerozxa
Copy link
Member

I would want to drink this water.

@Loppansson
Copy link
Contributor Author

I would want to drink this water.

Haha^^ That seams like a good "is it good-enough" check for water textures:)

@appgurueu
Copy link
Contributor

Here's another shot without shaders and with more flowing water:
Screenshot

Copy link
Member

@sfan5 sfan5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good going by screenshots

@appgurueu
Copy link
Contributor

Merging this since free water is better than nonfree water. Further improvements to the textures can be proposed in later PRs.

@appgurueu appgurueu changed the title New water textures. Replace nonfree water textures Sep 4, 2023
@appgurueu appgurueu merged commit a4322c4 into minetest:master Sep 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replacements needed for water textures sourced from Minecraft texture packs
5 participants