Default: Allow papyrus growing on default:sand #654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -152,7 +152,8 @@ end | |||
| function default.grow_papyrus(pos, node) | |||
| pos.y = pos.y - 1 | |||
| local name = minetest.get_node(pos).name | |||
| if name ~= "default:dirt_with_grass" and name ~= "default:dirt" then | |||
| if name ~= "default:dirt_with_grass" and name ~= "default:dirt" and | |||
| name ~= "group:sand" then | |||
There was a problem hiding this comment.
if not name:find("dirt") and not name:find("sand") then
There was a problem hiding this comment.
- We don't want papyrus to grow on sandworm_spawners or on stuff registered by a toolsandblocks mod. Yes I made those examples up but we didn't ever do this in any other code, why do it here?
- Does this actually work? I don't think the name will be "group:sand" if it's in the sand group. Don't you need to look up the table of registered nodes for that?
- Also isn't the
nodeparameter to the function the exact same thing asminetest.get_node(pos)? If that is the case then the method call would be duplicate.
Mgv5/mgv7 papyrus schematic now has sand nodes as a base Add sand beach to mgv5/mgv7 deserts
|
Updated. Thanks for catching 'name' not working with 'group:sand'. I changed the added fertile node to be default:sand only, assumed to be wet sand near water. |
paramat
changed the title
paramat
changed the title
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
Mgv5/mgv7 papyrus schematic now has sand nodes as a base
Add beaches of default:sand to mgv5/mgv7 deserts
^ This commit
^ Currently
Sand base nodes blend with beaches and shallow water, it looks better.
In mgv5/mgv7 papyrus grows in shallow water in savanna and desert biomes, allowing papyrus to grow on sand allows growing on the beaches of these biomes without having to place dirt there first. In reality papyrus can grow in wet sandy soil.
The sand around the papyrus base can be considered sand that has got caught-up in, and collected around, the base of the papyrus.