Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beds: Fix code style issues #899

Closed
wants to merge 1 commit into from
Closed

Beds: Fix code style issues #899

wants to merge 1 commit into from

Conversation

paramat
Copy link
Contributor

@paramat paramat commented Mar 8, 2016

No description provided.

@paramat paramat added the WIP label Mar 8, 2016
@paramat paramat added this to the 0.4.14 milestone Mar 8, 2016
@sofar
Copy link
Contributor

sofar commented Mar 8, 2016

Is there any reason not to use group:wool instead?

@kilbith
Copy link
Contributor

kilbith commented Mar 8, 2016

No, please don't turn the blanket in white. Otherwise the white upper part (mat) and the blanket will be visually mixed without real distinction.

Leave it in red so that it remains attractive and cute. Add more flowers to Mapgen V7 if it's really a problem.

Also i think it would be good to visually distinguish Minetest beds from Minecraft ones.

Is there a valid reason to or it's just for its own sake ?

@0-afflatus
Copy link

Not white for the reasons @kilbith stated.
However, I would like to see multicoloured beds.
MT is not MC

@sofar
Copy link
Contributor

sofar commented Mar 8, 2016

@kilbith this patch doesn't change the visual appearance or color of the bed model. just the crafting recipe.

@kilbith
Copy link
Contributor

kilbith commented Mar 8, 2016

I was answering to :

SInce editing the textures will be a long job, i will wait for dev opinions on this PR before doing that.

@C1ffisme
Copy link

C1ffisme commented Mar 8, 2016

I would like multicolored beds, but only if we can have node meta set node definition.

In all mapgens other than mgv6, roses could possibly be 1000s of nodes away.

I'm not really sure about this statement. Could someone verify this? If they were thousands of nodes away, then they obviously need to be more common.

We could also make a crafting recipe for red dye from apples.

@0-afflatus
Copy link

Could someone verify this?

That's a bit of an overstatement, but you generally have to explore to find roses in mgv7.

@paramat
Copy link
Contributor Author

paramat commented Mar 8, 2016

I realised this is not an issue, since to get wool you need cotton seeds from junglegrass, and jungles are usually more distant than roses.
I was indeed going to change the textures, and am happy to avoid that now.
Flowers can be distant yes, but only because biomes are larger and more varied than in mgv6.

I will change this PR to be a code cleanup only, it really needs it.

@paramat paramat changed the title Beds: Craft beds from white wool Beds: Fix code style issues Mar 8, 2016
@paramat paramat added One approval and removed WIP labels Mar 9, 2016
@paramat
Copy link
Contributor Author

paramat commented Mar 9, 2016

Updated to clean up code in all files.
Added my own approval to labels.
WIll merge soon as is trivial.

@paramat
Copy link
Contributor Author

paramat commented Mar 9, 2016

45bc0b2

@paramat paramat closed this Mar 9, 2016
@paramat paramat deleted the whitebeds branch March 14, 2016 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants